Skip to content

Commit

Permalink
userfaultfd: use helper function range_in_vma()
Browse files Browse the repository at this point in the history
We can use range_in_vma() to check if dst_start, dst_start + len are
within the dst_vma range.  Minor readability improvement.

Link: https://lkml.kernel.org/r/20230417003919.930515-1-zhangpeng362@huawei.com
Signed-off-by: ZhangPeng <zhangpeng362@huawei.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Nanyong Sun <sunnanyong@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
ZhangPeng authored and Andrew Morton committed Apr 21, 2023
1 parent 13215e8 commit 686ea6e
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions mm/userfaultfd.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,7 @@ struct vm_area_struct *find_dst_vma(struct mm_struct *dst_mm,
struct vm_area_struct *dst_vma;

dst_vma = find_vma(dst_mm, dst_start);
if (!dst_vma)
return NULL;

if (dst_start < dst_vma->vm_start ||
dst_start + len > dst_vma->vm_end)
if (!range_in_vma(dst_vma, dst_start, dst_start + len))
return NULL;

/*
Expand Down

0 comments on commit 686ea6e

Please sign in to comment.