Skip to content

Commit

Permalink
ACPI: platform_profile: Allow multiple handlers
Browse files Browse the repository at this point in the history
Multiple drivers may attempt to register platform profile handlers,
but only one may be registered and the behavior is non-deterministic
for which one wins.  It's mostly controlled by probing order.

This can be problematic if one driver changes CPU settings and another
driver notifies the EC for changing fan curves.

Modify the ACPI platform profile handler to let multiple drivers
register platform profile handlers and abstract this detail from userspace.

To avoid undefined behaviors only offer profiles that are commonly
advertised across multiple handlers.

If any problems occur when changing profiles for any driver, then the
drivers that were already changed remain changed and the legacy sysfs
handler will report 'custom'.

Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Tested-by: Matthew Schwartz <matthew.schwartz@linux.dev>
Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20241206031918.1537-21-mario.limonciello@amd.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
  • Loading branch information
Mario Limonciello authored and Ilpo Järvinen committed Dec 10, 2024
1 parent 37a6853 commit 6888347
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions drivers/acpi/platform_profile.c
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <linux/platform_profile.h>
#include <linux/sysfs.h>

static struct platform_profile_handler *cur_profile;
static DEFINE_MUTEX(profile_lock);

static const char * const profile_names[] = {
Expand Down Expand Up @@ -410,8 +409,6 @@ static const struct attribute_group platform_profile_group = {

void platform_profile_notify(struct platform_profile_handler *pprof)
{
if (!cur_profile)
return;
scoped_cond_guard(mutex_intr, return, &profile_lock) {
_notify_class_profile(pprof->class_dev, NULL);
}
Expand Down Expand Up @@ -474,9 +471,6 @@ int platform_profile_register(struct platform_profile_handler *pprof)
}

guard(mutex)(&profile_lock);
/* We can only have one active profile */
if (cur_profile)
return -EEXIST;

/* create class interface for individual handler */
pprof->minor = ida_alloc(&platform_profile_ida, GFP_KERNEL);
Expand All @@ -492,16 +486,13 @@ int platform_profile_register(struct platform_profile_handler *pprof)

sysfs_notify(acpi_kobj, NULL, "platform_profile");

cur_profile = pprof;

err = sysfs_update_group(acpi_kobj, &platform_profile_group);
if (err)
goto cleanup_cur;

return 0;

cleanup_cur:
cur_profile = NULL;
device_unregister(pprof->class_dev);

cleanup_ida:
Expand All @@ -516,8 +507,6 @@ int platform_profile_remove(struct platform_profile_handler *pprof)
int id;
guard(mutex)(&profile_lock);

cur_profile = NULL;

id = pprof->minor;
device_unregister(pprof->class_dev);
ida_free(&platform_profile_ida, id);
Expand Down

0 comments on commit 6888347

Please sign in to comment.