Skip to content

Commit

Permalink
drivers: thermal: tsens: Function prototypes should have argument names
Browse files Browse the repository at this point in the history
check_patch complains a lot as follows:

WARNING: function definition argument 'struct tsens_priv *' should also have an identifier name
+       int (*init)(struct tsens_priv *);

Fix it.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
  • Loading branch information
Amit Kucheria authored and Eduardo Valentin committed May 14, 2019
1 parent 2cbcd2e commit 68b3314
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions drivers/thermal/qcom/tsens.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@ struct tsens_sensor {
*/
struct tsens_ops {
/* mandatory callbacks */
int (*init)(struct tsens_priv *);
int (*calibrate)(struct tsens_priv *);
int (*get_temp)(struct tsens_priv *, int, int *);
int (*init)(struct tsens_priv *priv);
int (*calibrate)(struct tsens_priv *priv);
int (*get_temp)(struct tsens_priv *priv, int i, int *temp);
/* optional callbacks */
int (*enable)(struct tsens_priv *, int);
void (*disable)(struct tsens_priv *);
int (*suspend)(struct tsens_priv *);
int (*resume)(struct tsens_priv *);
int (*get_trend)(struct tsens_priv *, int, enum thermal_trend *);
int (*enable)(struct tsens_priv *priv, int i);
void (*disable)(struct tsens_priv *priv);
int (*suspend)(struct tsens_priv *priv);
int (*resume)(struct tsens_priv *priv);
int (*get_trend)(struct tsens_priv *priv, int i, enum thermal_trend *trend);
};

enum reg_list {
Expand Down Expand Up @@ -111,10 +111,10 @@ struct tsens_priv {
struct tsens_sensor sensor[0];
};

char *qfprom_read(struct device *, const char *);
void compute_intercept_slope(struct tsens_priv *, u32 *, u32 *, u32);
int init_common(struct tsens_priv *);
int get_temp_common(struct tsens_priv *, int, int *);
char *qfprom_read(struct device *dev, const char *cname);
void compute_intercept_slope(struct tsens_priv *priv, u32 *pt1, u32 *pt2, u32 mode);
int init_common(struct tsens_priv *priv);
int get_temp_common(struct tsens_priv *priv, int i, int *temp);

/* TSENS v1 targets */
extern const struct tsens_plat_data data_8916, data_8974, data_8960;
Expand Down

0 comments on commit 68b3314

Please sign in to comment.