Skip to content

Commit

Permalink
extcon: max8997: Fix incorrect error check and return value
Browse files Browse the repository at this point in the history
irq_create_mapping() returns 0 if it fails to provide a valid irq number.
'ret' needs to be updated with a negative error code before returning from
probe to signal probe failure. While at it, also corrected the 'virq' type to
unsigned from signed.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Myungjoo Ham <myungjoo.ham@samsung.com>
  • Loading branch information
Sachin Kamat authored and MyungJoo Ham committed Nov 21, 2012
1 parent c0c078c commit 68c9274
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/extcon/extcon-max8997.c
Original file line number Diff line number Diff line change
Expand Up @@ -450,11 +450,13 @@ static int __devinit max8997_muic_probe(struct platform_device *pdev)

for (i = 0; i < ARRAY_SIZE(muic_irqs); i++) {
struct max8997_muic_irq *muic_irq = &muic_irqs[i];
int virq = 0;
unsigned int virq = 0;

virq = irq_create_mapping(max8997->irq_domain, muic_irq->irq);
if (!virq)
if (!virq) {
ret = -EINVAL;
goto err_irq;
}
muic_irq->virq = virq;

ret = request_threaded_irq(virq, NULL,max8997_muic_irq_handler,
Expand Down

0 comments on commit 68c9274

Please sign in to comment.