Skip to content

Commit

Permalink
wifi: mac80211: drop spurious WARN_ON() in ieee80211_ibss_csa_beacon()
Browse files Browse the repository at this point in the history
The WARN_ON() in subject was actually seen only once, with 5.10.200
under syzkaller. It looks like a weird artifact of (ab?)using the
syzkaller itself [1], and hopefully may be safely removed.

[1] https://lore.kernel.org/linux-wireless/1bd8f266-dee0-4d4e-9b50-e22546b55763@yandex.ru/T/#u

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Link: https://msgid.link/20231208153130.107409-1-dmantipov@yandex.ru
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
  • Loading branch information
Dmitry Antipov authored and Johannes Berg committed Dec 12, 2023
1 parent 6a9c8ed commit 68d83f0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/mac80211/ibss.c
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ int ieee80211_ibss_csa_beacon(struct ieee80211_sub_if_data *sdata,
ifibss->ssid_len, IEEE80211_BSS_TYPE_IBSS,
IEEE80211_PRIVACY(ifibss->privacy));

if (WARN_ON(!cbss))
if (unlikely(!cbss))
return -EINVAL;

rcu_read_lock();
Expand Down

0 comments on commit 68d83f0

Please sign in to comment.