Skip to content

Commit

Permalink
net_sched: fix another regression in cls_tcindex
Browse files Browse the repository at this point in the history
Clearly the following change is not expected:

	-       if (!cp.perfect && !cp.h)
	-               cp.alloc_hash = cp.hash;
	+       if (!cp->perfect && cp->h)
	+               cp->alloc_hash = cp->hash;

Fixes: commit 331b729 ("net: sched: RCU cls_tcindex")
Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
WANG Cong authored and David S. Miller committed Sep 28, 2014
1 parent 02c5e84 commit 68f6a7c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/sched/cls_tcindex.c
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ tcindex_set_parms(struct net *net, struct tcf_proto *tp, unsigned long base,
cp->hash = DEFAULT_HASH_SIZE;
}

if (!cp->perfect && cp->h)
if (!cp->perfect && !cp->h)
cp->alloc_hash = cp->hash;

/* Note: this could be as restrictive as if (handle & ~(mask >> shift))
Expand Down

0 comments on commit 68f6a7c

Please sign in to comment.