Skip to content

Commit

Permalink
pwm: Autodetect default value for of_pwm_n_cells from device tree
Browse files Browse the repository at this point in the history
This allows to simplify all drivers that use three pwm-cells.
The only ugly side effect is that if a driver specified of_pwm_n_cells = 2
it suddenly supports device trees that use #pwm-cells = <3>. This however
isn't a bad thing because the driver doesn't need explicit support for
three cells as the core handles all the details. Also there is no such
in-tree driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
  • Loading branch information
Uwe Kleine-König authored and Thierry Reding committed May 25, 2021
1 parent 5447e78 commit 69230cf
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion drivers/pwm/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,14 @@ static void of_pwmchip_add(struct pwm_chip *chip)
return;

if (!chip->of_xlate) {
u32 pwm_cells;

if (of_property_read_u32(chip->dev->of_node, "#pwm-cells",
&pwm_cells))
pwm_cells = 2;

chip->of_xlate = of_pwm_xlate_with_flags;
chip->of_pwm_n_cells = 2;
chip->of_pwm_n_cells = pwm_cells;
}

of_node_get(chip->dev->of_node);
Expand Down

0 comments on commit 69230cf

Please sign in to comment.