Skip to content

Commit

Permalink
uapi/if_ether.h: prevent redefinition of struct ethhdr
Browse files Browse the repository at this point in the history
Musl provides its own ethhdr struct definition. Add a guard to prevent
its definition of the appropriate musl header has already been included.

glibc does not implement this header, but when glibc will implement this
they can just define __UAPI_DEF_ETHHDR 0 to make it work with the
kernel.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Hauke Mehrtens authored and David S. Miller committed Jan 4, 2018
1 parent 7bbfe00 commit 6926e04
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
3 changes: 3 additions & 0 deletions include/uapi/linux/if_ether.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#define _UAPI_LINUX_IF_ETHER_H

#include <linux/types.h>
#include <linux/libc-compat.h>

/*
* IEEE 802.3 Ethernet magic constants. The frame sizes omit the preamble
Expand Down Expand Up @@ -149,11 +150,13 @@
* This is an Ethernet frame header.
*/

#if __UAPI_DEF_ETHHDR
struct ethhdr {
unsigned char h_dest[ETH_ALEN]; /* destination eth addr */
unsigned char h_source[ETH_ALEN]; /* source ether addr */
__be16 h_proto; /* packet type ID field */
} __attribute__((packed));
#endif


#endif /* _UAPI_LINUX_IF_ETHER_H */
6 changes: 6 additions & 0 deletions include/uapi/linux/libc-compat.h
Original file line number Diff line number Diff line change
Expand Up @@ -264,4 +264,10 @@

#endif /* __GLIBC__ */

/* Definitions for if_ether.h */
/* allow libcs like musl to deactivate this, glibc does not implement this. */
#ifndef __UAPI_DEF_ETHHDR
#define __UAPI_DEF_ETHHDR 1
#endif

#endif /* _UAPI_LIBC_COMPAT_H */

0 comments on commit 6926e04

Please sign in to comment.