Skip to content

Commit

Permalink
net/3com: Make el3_netdev_get_ecmd return void
Browse files Browse the repository at this point in the history 
Make return value void since function never returns meaningfull value.

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
yuval.shaia@oracle.com authored and David S. Miller committed Jun 5, 2017
1 parent 82c01a8 commit 697dae1
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions drivers/net/ethernet/3com/3c509.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1039,7 +1039,7 @@ el3_link_ok(struct net_device *dev)
return tmp & (1<<11);
}

static int
static void
el3_netdev_get_ecmd(struct net_device *dev, struct ethtool_link_ksettings *cmd)
{
u16 tmp;
Expand Down Expand Up @@ -1082,7 +1082,6 @@ el3_netdev_get_ecmd(struct net_device *dev, struct ethtool_link_ksettings *cmd)
supported);
cmd->base.speed = SPEED_10;
EL3WINDOW(1);
return 0;
}

static int
Expand Down Expand Up @@ -1151,12 +1150,11 @@ static int el3_get_link_ksettings(struct net_device *dev,
struct ethtool_link_ksettings *cmd)
{
struct el3_private *lp = netdev_priv(dev);
int ret;

spin_lock_irq(&lp->lock);
ret = el3_netdev_get_ecmd(dev, cmd);
el3_netdev_get_ecmd(dev, cmd);
spin_unlock_irq(&lp->lock);
return ret;
return 0;
}

static int el3_set_link_ksettings(struct net_device *dev,
Expand Down

0 comments on commit 697dae1

Please sign in to comment.