Skip to content

Commit

Permalink
net: ipa: introduce gsi_channel_stop_retry()
Browse files Browse the repository at this point in the history
Create a new helper function that encapsulates issuing a set of
channel stop commands, retrying if appropriate, with a short delay
between attempts.

Signed-off-by: Alex Elder <elder@linaro.org>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Alex Elder authored and Jakub Kicinski committed Feb 3, 2021
1 parent 6b00a76 commit 697e834
Showing 1 changed file with 15 additions and 5 deletions.
20 changes: 15 additions & 5 deletions drivers/net/ipa/gsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -892,15 +892,12 @@ int gsi_channel_start(struct gsi *gsi, u32 channel_id)
return ret;
}

/* Stop a started channel */
int gsi_channel_stop(struct gsi *gsi, u32 channel_id)
static int gsi_channel_stop_retry(struct gsi_channel *channel)
{
struct gsi_channel *channel = &gsi->channel[channel_id];
u32 retries = GSI_CHANNEL_STOP_RETRIES;
struct gsi *gsi = channel->gsi;
int ret;

gsi_channel_freeze(channel);

mutex_lock(&gsi->mutex);

do {
Expand All @@ -912,6 +909,19 @@ int gsi_channel_stop(struct gsi *gsi, u32 channel_id)

mutex_unlock(&gsi->mutex);

return ret;
}

/* Stop a started channel */
int gsi_channel_stop(struct gsi *gsi, u32 channel_id)
{
struct gsi_channel *channel = &gsi->channel[channel_id];
int ret;

gsi_channel_freeze(channel);

ret = gsi_channel_stop_retry(channel);

/* Re-thaw the channel if an error occurred while stopping */
if (ret)
gsi_channel_thaw(channel);
Expand Down

0 comments on commit 697e834

Please sign in to comment.