Skip to content

Commit

Permalink
ftrace: Decouple hash items from showing filtered functions
Browse files Browse the repository at this point in the history
The set_ftrace_filter shows "hashed" functions, which are functions
that are added with operations to them (like traceon and traceoff).

As other subsystems may be able to show what functions they are
using for function tracing, the hash items should no longer
be shown just because the FILTER flag is set. As they have nothing
to do with other subsystems filters.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Steven Rostedt authored and Steven Rostedt committed Dec 21, 2011
1 parent fc13cb0 commit 69a3083
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 10 deletions.
5 changes: 3 additions & 2 deletions include/linux/ftrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,9 @@ enum {
FTRACE_ITER_FILTER = (1 << 0),
FTRACE_ITER_NOTRACE = (1 << 1),
FTRACE_ITER_PRINTALL = (1 << 2),
FTRACE_ITER_HASH = (1 << 3),
FTRACE_ITER_ENABLED = (1 << 4),
FTRACE_ITER_DO_HASH = (1 << 3),
FTRACE_ITER_HASH = (1 << 4),
FTRACE_ITER_ENABLED = (1 << 5),
};

void arch_ftrace_update_code(int command);
Expand Down
16 changes: 8 additions & 8 deletions kernel/trace/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -2198,6 +2198,9 @@ static void *t_hash_start(struct seq_file *m, loff_t *pos)
void *p = NULL;
loff_t l;

if (!(iter->flags & FTRACE_ITER_DO_HASH))
return NULL;

if (iter->func_pos > *pos)
return NULL;

Expand Down Expand Up @@ -2343,12 +2346,8 @@ static void *t_start(struct seq_file *m, loff_t *pos)
break;
}

if (!p) {
if (iter->flags & FTRACE_ITER_FILTER)
return t_hash_start(m, pos);

return NULL;
}
if (!p)
return t_hash_start(m, pos);

return iter;
}
Expand Down Expand Up @@ -2541,8 +2540,9 @@ ftrace_regex_open(struct ftrace_ops *ops, int flag,
static int
ftrace_filter_open(struct inode *inode, struct file *file)
{
return ftrace_regex_open(&global_ops, FTRACE_ITER_FILTER,
inode, file);
return ftrace_regex_open(&global_ops,
FTRACE_ITER_FILTER | FTRACE_ITER_DO_HASH,
inode, file);
}

static int
Expand Down

0 comments on commit 69a3083

Please sign in to comment.