Skip to content

Commit

Permalink
can: slcan: convert comparison to NULL into !val
Browse files Browse the repository at this point in the history
All comparison to NULL could be written "!val", convert them to make
checkpatch happy.

Link: https://lore.kernel.org/all/20220704125954.1587880-5-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
  • Loading branch information
Marc Kleine-Budde committed Jul 19, 2022
1 parent f07d9e3 commit 69a6539
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions drivers/net/can/slcan/slcan-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ static netdev_tx_t slc_xmit(struct sk_buff *skb, struct net_device *dev)
netdev_warn(dev, "xmit: iface is down\n");
goto out;
}
if (sl->tty == NULL) {
if (!sl->tty) {
spin_unlock(&sl->lock);
goto out;
}
Expand Down Expand Up @@ -707,7 +707,7 @@ static int slc_open(struct net_device *dev)
unsigned char cmd[SLC_MTU];
int err, s;

if (sl->tty == NULL)
if (!sl->tty)
return -ENODEV;

/* The baud rate is not set with the command
Expand Down Expand Up @@ -834,7 +834,7 @@ static void slc_sync(void)

for (i = 0; i < maxdev; i++) {
dev = slcan_devs[i];
if (dev == NULL)
if (!dev)
break;

sl = netdev_priv(dev);
Expand All @@ -854,9 +854,8 @@ static struct slcan *slc_alloc(void)

for (i = 0; i < maxdev; i++) {
dev = slcan_devs[i];
if (dev == NULL)
if (!dev)
break;

}

/* Sorry, too many, all slots in use */
Expand Down Expand Up @@ -902,7 +901,7 @@ static int slcan_open(struct tty_struct *tty)
if (!capable(CAP_NET_ADMIN))
return -EPERM;

if (tty->ops->write == NULL)
if (!tty->ops->write)
return -EOPNOTSUPP;

/* RTnetlink lock is misused here to serialize concurrent
Expand All @@ -924,7 +923,7 @@ static int slcan_open(struct tty_struct *tty)
/* OK. Find a free SLCAN channel to use. */
err = -ENFILE;
sl = slc_alloc();
if (sl == NULL)
if (!sl)
goto err_exit;

sl->tty = tty;
Expand Down Expand Up @@ -1071,7 +1070,7 @@ static void __exit slcan_exit(void)
unsigned long timeout = jiffies + HZ;
int busy = 0;

if (slcan_devs == NULL)
if (!slcan_devs)
return;

/* First of all: check for active disciplines and hangup them.
Expand Down

0 comments on commit 69a6539

Please sign in to comment.