Skip to content

Commit

Permalink
USB: serial: mos7720: always require an interrupt endpoint
Browse files Browse the repository at this point in the history
This driver have treated the interrupt endpoint as optional despite it
always being present (according to the datasheet). Let's consider it
mandatory instead.

Signed-off-by: Johan Hovold <johan@kernel.org>
  • Loading branch information
Johan Hovold committed Mar 28, 2017
1 parent d760557 commit 6a1eaf1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/usb/serial/mos7720.c
Original file line number Diff line number Diff line change
Expand Up @@ -1923,8 +1923,7 @@ static int mos7720_startup(struct usb_serial *serial)
if (product == MOSCHIP_DEVICE_ID_7715) {
struct urb *urb = serial->port[0]->interrupt_in_urb;

if (urb)
urb->complete = mos7715_interrupt_callback;
urb->complete = mos7715_interrupt_callback;

#ifdef CONFIG_USB_SERIAL_MOS7715_PARPORT
ret_val = mos7715_parport_init(serial);
Expand Down Expand Up @@ -2025,6 +2024,7 @@ static struct usb_serial_driver moschip7720_2port_driver = {
.id_table = id_table,
.num_bulk_in = 2,
.num_bulk_out = 2,
.num_interrupt_in = 1,
.calc_num_ports = mos77xx_calc_num_ports,
.open = mos7720_open,
.close = mos7720_close,
Expand Down

0 comments on commit 6a1eaf1

Please sign in to comment.