Skip to content

Commit

Permalink
vme: vme_get_size potentially returning incorrect value on failure
Browse files Browse the repository at this point in the history
The function vme_get_size returns the size of the window to the caller,
however it doesn't check the return value of the call to vme_master_get.

Return 0 on failure rather than anything else.

Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martyn Welch <martyn.welch@collabora.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Martyn Welch authored and Greg Kroah-Hartman committed Oct 28, 2016
1 parent cfcc145 commit 6ad3756
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/vme/vme.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,12 +156,16 @@ size_t vme_get_size(struct vme_resource *resource)
case VME_MASTER:
retval = vme_master_get(resource, &enabled, &base, &size,
&aspace, &cycle, &dwidth);
if (retval)
return 0;

return size;
break;
case VME_SLAVE:
retval = vme_slave_get(resource, &enabled, &base, &size,
&buf_base, &aspace, &cycle);
if (retval)
return 0;

return size;
break;
Expand Down

0 comments on commit 6ad3756

Please sign in to comment.