Skip to content

Commit

Permalink
dmaengine: virt-dma: Add helper to free/reuse a descriptor
Browse files Browse the repository at this point in the history
The vchan_vdesc_fini() can be used to free or reuse a given descriptor
after it has been marked as completed.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
  • Loading branch information
Peter Ujfalusi authored and Vinod Koul committed Dec 4, 2017
1 parent 4fbd8d1 commit 6af149d
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/dma/virt-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,7 @@ static void vchan_complete(unsigned long arg)
dmaengine_desc_get_callback(&vd->tx, &cb);

list_del(&vd->node);
if (dmaengine_desc_test_reuse(&vd->tx))
list_add(&vd->node, &vc->desc_allocated);
else
vc->desc_free(vd);
vchan_vdesc_fini(vd);

dmaengine_desc_callback_invoke(&cb, NULL);
}
Expand Down
14 changes: 14 additions & 0 deletions drivers/dma/virt-dma.h
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,20 @@ static inline void vchan_cookie_complete(struct virt_dma_desc *vd)
tasklet_schedule(&vc->task);
}

/**
* vchan_vdesc_fini - Free or reuse a descriptor
* @vd: virtual descriptor to free/reuse
*/
static inline void vchan_vdesc_fini(struct virt_dma_desc *vd)
{
struct virt_dma_chan *vc = to_virt_chan(vd->tx.chan);

if (dmaengine_desc_test_reuse(&vd->tx))
list_add(&vd->node, &vc->desc_allocated);
else
vc->desc_free(vd);
}

/**
* vchan_cyclic_callback - report the completion of a period
* @vd: virtual descriptor
Expand Down

0 comments on commit 6af149d

Please sign in to comment.