Skip to content

Commit

Permalink
lib/test_cpumask: drop cpu_possible_mask full test
Browse files Browse the repository at this point in the history
When the number of CPUs that can possibly be brought online is known at
boot time, e.g. when HOTPLUG is disabled, nr_cpu_ids may be smaller than
NR_CPUS. In that case, cpu_possible_mask would not be completely filled,
and cpumask_full(cpu_possible_mask) can return false for valid system
configurations.

Without this test, cpu_possible_mask contents are still constrained by
a check on cpumask_weight(), as well as tests in test_cpumask_first(),
test_cpumask_last(), test_cpumask_next(), and test_cpumask_iterators().

Fixes: c41e886 ("lib/test: introduce cpumask KUnit test suite")
Link: https://lore.kernel.org/lkml/346cb279-8e75-24b0-7d12-9803f2b41c73@riseup.net/
Reported-by: Maíra Canal <mairacanal@riseup.net>
Signed-off-by: Sander Vanheule <sander@svanheule.net>
Tested-by: Maíra Canal <mairacanal@riseup.net>
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: Yury Norov <yury.norov@gmail.com>
  • Loading branch information
Sander Vanheule authored and Yury Norov committed Aug 24, 2022
1 parent 1c23f9e commit 6afd9db
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/test_cpumask.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ static cpumask_t mask_all;
static void test_cpumask_weight(struct kunit *test)
{
KUNIT_EXPECT_TRUE(test, cpumask_empty(&mask_empty));
KUNIT_EXPECT_TRUE(test, cpumask_full(cpu_possible_mask));
KUNIT_EXPECT_TRUE(test, cpumask_full(&mask_all));

KUNIT_EXPECT_EQ(test, 0, cpumask_weight(&mask_empty));
Expand Down

0 comments on commit 6afd9db

Please sign in to comment.