Skip to content

Commit

Permalink
target: update error handling for sbc_setup_write_same()
Browse files Browse the repository at this point in the history
We recently changed this to return positive subsystem error codes so the
error handling needs to be updated.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Dan Carpenter authored and Nicholas Bellinger committed Nov 28, 2012
1 parent 3c989d7 commit 6b64e1f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/target/target_core_sbc.c
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
cmd->t_task_lba = get_unaligned_be64(&cdb[12]);

ret = sbc_setup_write_same(cmd, &cdb[10], ops);
if (ret < 0)
if (ret)
return ret;
break;
default:
Expand Down Expand Up @@ -510,7 +510,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
cmd->t_task_lba = get_unaligned_be64(&cdb[2]);

ret = sbc_setup_write_same(cmd, &cdb[1], ops);
if (ret < 0)
if (ret)
return ret;
break;
case WRITE_SAME:
Expand All @@ -528,7 +528,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
* of byte 1 bit 3 UNMAP instead of original reserved field
*/
ret = sbc_setup_write_same(cmd, &cdb[1], ops);
if (ret < 0)
if (ret)
return ret;
break;
case VERIFY:
Expand Down

0 comments on commit 6b64e1f

Please sign in to comment.