Skip to content

Commit

Permalink
powerpc/ps3: Fix vuart sparse warnings
Browse files Browse the repository at this point in the history
Fix sparse warnings like these:

  drivers/ps3/ps3-vuart.c: warning: symbol 'ps3_vuart_disable_interrupt_tx' was not declared. Should it be static?

Signed-off-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Geoff Levand authored and Michael Ellerman committed Jan 22, 2015
1 parent 5ae7463 commit 6baa5ec
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/ps3/ps3-vuart.c
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,6 @@ static void __maybe_unused _dump_port_params(unsigned int port_number,
#endif
}

struct vuart_triggers {
unsigned long rx;
unsigned long tx;
};

int ps3_vuart_get_triggers(struct ps3_system_bus_device *dev,
struct vuart_triggers *trig)
{
Expand Down
16 changes: 16 additions & 0 deletions drivers/ps3/vuart.h
Original file line number Diff line number Diff line change
Expand Up @@ -82,4 +82,20 @@ void ps3_vuart_cancel_async(struct ps3_system_bus_device *dev);
void ps3_vuart_clear_rx_bytes(struct ps3_system_bus_device *dev,
unsigned int bytes);

struct vuart_triggers {
unsigned long rx;
unsigned long tx;
};

int ps3_vuart_get_triggers(struct ps3_system_bus_device *dev,
struct vuart_triggers *trig);
int ps3_vuart_set_triggers(struct ps3_system_bus_device *dev, unsigned int tx,
unsigned int rx);
int ps3_vuart_enable_interrupt_tx(struct ps3_system_bus_device *dev);
int ps3_vuart_disable_interrupt_tx(struct ps3_system_bus_device *dev);
int ps3_vuart_enable_interrupt_rx(struct ps3_system_bus_device *dev);
int ps3_vuart_disable_interrupt_rx(struct ps3_system_bus_device *dev);
int ps3_vuart_enable_interrupt_disconnect(struct ps3_system_bus_device *dev);
int ps3_vuart_disable_interrupt_disconnect(struct ps3_system_bus_device *dev);

#endif

0 comments on commit 6baa5ec

Please sign in to comment.