Skip to content

Commit

Permalink
libahci_platform: Staticize ahci_platform_<en/dis>able_phys()
Browse files Browse the repository at this point in the history
ahci_platform_enable_phys() and ahci_platform_disable_phys() are currently
exported, but they are not used anywhere else other than libahci_platform.c.

So make them static and do not export them to fix the following sparse
warnings:

drivers/ata/libahci_platform.c:52:5: warning: symbol 'ahci_platform_enable_phys' was not declared. Should it be static?
drivers/ata/libahci_platform.c:88:6: warning: symbol 'ahci_platform_disable_phys' was not declared. Should it be static?

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Fabio Estevam authored and Tejun Heo committed Aug 31, 2014
1 parent 53f3cc4 commit 6bb86fe
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/ata/libahci_platform.c
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ static struct scsi_host_template ahci_platform_sht = {
* RETURNS:
* 0 on success otherwise a negative error code
*/
int ahci_platform_enable_phys(struct ahci_host_priv *hpriv)
static int ahci_platform_enable_phys(struct ahci_host_priv *hpriv)
{
int rc, i;

Expand Down Expand Up @@ -77,15 +77,14 @@ int ahci_platform_enable_phys(struct ahci_host_priv *hpriv)
}
return rc;
}
EXPORT_SYMBOL_GPL(ahci_platform_enable_phys);

/**
* ahci_platform_disable_phys - Disable PHYs
* @hpriv: host private area to store config values
*
* This function disables all PHYs found in hpriv->phys.
*/
void ahci_platform_disable_phys(struct ahci_host_priv *hpriv)
static void ahci_platform_disable_phys(struct ahci_host_priv *hpriv)
{
int i;

Expand All @@ -97,7 +96,6 @@ void ahci_platform_disable_phys(struct ahci_host_priv *hpriv)
phy_exit(hpriv->phys[i]);
}
}
EXPORT_SYMBOL_GPL(ahci_platform_disable_phys);

/**
* ahci_platform_enable_clks - Enable platform clocks
Expand Down

0 comments on commit 6bb86fe

Please sign in to comment.