Skip to content

Commit

Permalink
ASoC: wm97xx: fix compilation corner case
Browse files Browse the repository at this point in the history
When the old AC97 is not used, CONFIG_SND_SOC_AC97_BUS is not
defined. As a consequence, in the error path, snd_soc_free_ac97_codec()
is not defined and triggers a compilation error.

Fix it for wm9705 and wm9712, as wm9713 is correctly written.

Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Robert Jarzmik authored and Mark Brown committed Oct 18, 2017
1 parent 5aa3b03 commit 6bd25aa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 11 deletions.
8 changes: 2 additions & 6 deletions sound/soc/codecs/wm9705.c
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,6 @@ static int wm9705_soc_probe(struct snd_soc_codec *codec)
{
struct wm9705_priv *wm9705 = snd_soc_codec_get_drvdata(codec);
struct regmap *regmap;
int ret;

if (wm9705->mfd_pdata) {
wm9705->ac97 = wm9705->mfd_pdata->ac97;
Expand All @@ -337,8 +336,8 @@ static int wm9705_soc_probe(struct snd_soc_codec *codec)

regmap = regmap_init_ac97(wm9705->ac97, &wm9705_regmap_config);
if (IS_ERR(regmap)) {
ret = PTR_ERR(regmap);
goto err_free_ac97_codec;
snd_soc_free_ac97_codec(wm9705->ac97);
return PTR_ERR(regmap);
}
#endif
}
Expand All @@ -347,9 +346,6 @@ static int wm9705_soc_probe(struct snd_soc_codec *codec)
snd_soc_codec_init_regmap(codec, regmap);

return 0;
err_free_ac97_codec:
snd_soc_free_ac97_codec(wm9705->ac97);
return ret;
}

static int wm9705_soc_remove(struct snd_soc_codec *codec)
Expand Down
7 changes: 2 additions & 5 deletions sound/soc/codecs/wm9712.c
Original file line number Diff line number Diff line change
Expand Up @@ -656,8 +656,8 @@ static int wm9712_soc_probe(struct snd_soc_codec *codec)

regmap = regmap_init_ac97(wm9712->ac97, &wm9712_regmap_config);
if (IS_ERR(regmap)) {
ret = PTR_ERR(regmap);
goto err_free_ac97_codec;
snd_soc_free_ac97_codec(wm9712->ac97);
return PTR_ERR(regmap);
}
#endif
}
Expand All @@ -668,9 +668,6 @@ static int wm9712_soc_probe(struct snd_soc_codec *codec)
snd_soc_update_bits(codec, AC97_VIDEO, 0x3000, 0x3000);

return 0;
err_free_ac97_codec:
snd_soc_free_ac97_codec(wm9712->ac97);
return ret;
}

static int wm9712_soc_remove(struct snd_soc_codec *codec)
Expand Down

0 comments on commit 6bd25aa

Please sign in to comment.