Skip to content

Commit

Permalink
Revert "video:uvesafb: Fix oops that uvesafb try to execute NX-protec…
Browse files Browse the repository at this point in the history
…ted page"

This reverts commit ec0d22e.

This patch requires exporting 'pcibios_enabled' to avoid breaking
modular uvesafb builds. As this gets some opposition by Alan Cox it
needs more discussion, revert the patch for now.

Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
  • Loading branch information
Florian Tobias Schandinat authored and Florian Tobias Schandinat committed Mar 21, 2012
1 parent dc7e57f commit 6bff98b
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions drivers/video/uvesafb.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include <video/uvesafb.h>
#ifdef CONFIG_X86
#include <video/vga.h>
#include <linux/pci.h>
#endif
#ifdef CONFIG_MTRR
#include <asm/mtrr.h>
Expand Down Expand Up @@ -816,15 +815,8 @@ static int __devinit uvesafb_vbe_init(struct fb_info *info)
par->pmi_setpal = pmi_setpal;
par->ypan = ypan;

if (par->pmi_setpal || par->ypan) {
if (pcibios_enabled) {
uvesafb_vbe_getpmi(task, par);
} else {
par->pmi_setpal = par->ypan = 0;
printk(KERN_WARNING "uvesafb: PCI BIOS area is NX."
"Can't use protected mode interface\n");
}
}
if (par->pmi_setpal || par->ypan)
uvesafb_vbe_getpmi(task, par);
#else
/* The protected mode interface is not available on non-x86. */
par->pmi_setpal = par->ypan = 0;
Expand Down

0 comments on commit 6bff98b

Please sign in to comment.