Skip to content

Commit

Permalink
iommu/exynos: Rework iommu group initialization
Browse files Browse the repository at this point in the history
This patch replaces custom code in add_device implementation with
iommu_group_get_for_dev() call and provides the needed callback.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
  • Loading branch information
Marek Szyprowski authored and Joerg Roedel committed Feb 25, 2016
1 parent 81f70ba commit 6c2ae7e
Showing 1 changed file with 16 additions and 11 deletions.
27 changes: 16 additions & 11 deletions drivers/iommu/exynos-iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -1114,28 +1114,32 @@ static phys_addr_t exynos_iommu_iova_to_phys(struct iommu_domain *iommu_domain,
return phys;
}

static struct iommu_group *get_device_iommu_group(struct device *dev)
{
struct iommu_group *group;

group = iommu_group_get(dev);
if (!group)
group = iommu_group_alloc();

return group;
}

static int exynos_iommu_add_device(struct device *dev)
{
struct iommu_group *group;
int ret;

if (!has_sysmmu(dev))
return -ENODEV;

group = iommu_group_get(dev);
group = iommu_group_get_for_dev(dev);

if (!group) {
group = iommu_group_alloc();
if (IS_ERR(group)) {
dev_err(dev, "Failed to allocate IOMMU group\n");
return PTR_ERR(group);
}
}
if (IS_ERR(group))
return PTR_ERR(group);

ret = iommu_group_add_device(group, dev);
iommu_group_put(group);

return ret;
return 0;
}

static void exynos_iommu_remove_device(struct device *dev)
Expand Down Expand Up @@ -1182,6 +1186,7 @@ static struct iommu_ops exynos_iommu_ops = {
.unmap = exynos_iommu_unmap,
.map_sg = default_iommu_map_sg,
.iova_to_phys = exynos_iommu_iova_to_phys,
.device_group = get_device_iommu_group,
.add_device = exynos_iommu_add_device,
.remove_device = exynos_iommu_remove_device,
.pgsize_bitmap = SECT_SIZE | LPAGE_SIZE | SPAGE_SIZE,
Expand Down

0 comments on commit 6c2ae7e

Please sign in to comment.