Skip to content

Commit

Permalink
drivers: net: replace UINT64_MAX with U64_MAX
Browse files Browse the repository at this point in the history
U64_MAX is well defined now while the UINT64_MAX is not, so we fall
back to drivers' own definition as below:

	#ifndef UINT64_MAX
	#define UINT64_MAX             (u64)(~((u64)0))
	#endif

I believe this is in one phy driver then copied and pasted to other phy
drivers.

Replace the UINT64_MAX with U64_MAX to clean up the source code.

Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jisheng Zhang authored and David S. Miller committed Apr 28, 2018
1 parent 80e95f4 commit 6c3442f
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 24 deletions.
6 changes: 3 additions & 3 deletions drivers/net/dsa/mv88e6xxx/chip.c
Original file line number Diff line number Diff line change
Expand Up @@ -665,13 +665,13 @@ static uint64_t _mv88e6xxx_get_ethtool_stat(struct mv88e6xxx_chip *chip,
case STATS_TYPE_PORT:
err = mv88e6xxx_port_read(chip, port, s->reg, &reg);
if (err)
return UINT64_MAX;
return U64_MAX;

low = reg;
if (s->size == 4) {
err = mv88e6xxx_port_read(chip, port, s->reg + 1, &reg);
if (err)
return UINT64_MAX;
return U64_MAX;
high = reg;
}
break;
Expand All @@ -685,7 +685,7 @@ static uint64_t _mv88e6xxx_get_ethtool_stat(struct mv88e6xxx_chip *chip,
mv88e6xxx_g1_stats_read(chip, reg + 1, &high);
break;
default:
return UINT64_MAX;
return U64_MAX;
}
value = (((u64)high) << 16) | low;
return value;
Expand Down
4 changes: 0 additions & 4 deletions drivers/net/dsa/mv88e6xxx/chip.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@
#include <linux/timecounter.h>
#include <net/dsa.h>

#ifndef UINT64_MAX
#define UINT64_MAX (u64)(~((u64)0))
#endif

#define SMI_CMD 0x00
#define SMI_CMD_BUSY BIT(15)
#define SMI_CMD_CLAUSE_22 BIT(12)
Expand Down
6 changes: 1 addition & 5 deletions drivers/net/phy/bcm-phy-lib.c
Original file line number Diff line number Diff line change
Expand Up @@ -346,10 +346,6 @@ void bcm_phy_get_strings(struct phy_device *phydev, u8 *data)
}
EXPORT_SYMBOL_GPL(bcm_phy_get_strings);

#ifndef UINT64_MAX
#define UINT64_MAX (u64)(~((u64)0))
#endif

/* Caller is supposed to provide appropriate storage for the library code to
* access the shadow copy
*/
Expand All @@ -362,7 +358,7 @@ static u64 bcm_phy_get_stat(struct phy_device *phydev, u64 *shadow,

val = phy_read(phydev, stat.reg);
if (val < 0) {
ret = UINT64_MAX;
ret = U64_MAX;
} else {
val >>= stat.shift;
val = val & ((1 << stat.bits) - 1);
Expand Down
5 changes: 1 addition & 4 deletions drivers/net/phy/marvell.c
Original file line number Diff line number Diff line change
Expand Up @@ -1482,9 +1482,6 @@ static void marvell_get_strings(struct phy_device *phydev, u8 *data)
}
}

#ifndef UINT64_MAX
#define UINT64_MAX (u64)(~((u64)0))
#endif
static u64 marvell_get_stat(struct phy_device *phydev, int i)
{
struct marvell_hw_stat stat = marvell_hw_stats[i];
Expand All @@ -1494,7 +1491,7 @@ static u64 marvell_get_stat(struct phy_device *phydev, int i)

val = phy_read_paged(phydev, stat.page, stat.reg);
if (val < 0) {
ret = UINT64_MAX;
ret = U64_MAX;
} else {
val = val & ((1 << stat.bits) - 1);
priv->stats[i] += val;
Expand Down
5 changes: 1 addition & 4 deletions drivers/net/phy/micrel.c
Original file line number Diff line number Diff line change
Expand Up @@ -650,9 +650,6 @@ static void kszphy_get_strings(struct phy_device *phydev, u8 *data)
}
}

#ifndef UINT64_MAX
#define UINT64_MAX (u64)(~((u64)0))
#endif
static u64 kszphy_get_stat(struct phy_device *phydev, int i)
{
struct kszphy_hw_stat stat = kszphy_hw_stats[i];
Expand All @@ -662,7 +659,7 @@ static u64 kszphy_get_stat(struct phy_device *phydev, int i)

val = phy_read(phydev, stat.reg);
if (val < 0) {
ret = UINT64_MAX;
ret = U64_MAX;
} else {
val = val & ((1 << stat.bits) - 1);
priv->stats[i] += val;
Expand Down
5 changes: 1 addition & 4 deletions drivers/net/phy/smsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,6 @@ static void smsc_get_strings(struct phy_device *phydev, u8 *data)
}
}

#ifndef UINT64_MAX
#define UINT64_MAX (u64)(~((u64)0))
#endif
static u64 smsc_get_stat(struct phy_device *phydev, int i)
{
struct smsc_hw_stat stat = smsc_hw_stats[i];
Expand All @@ -179,7 +176,7 @@ static u64 smsc_get_stat(struct phy_device *phydev, int i)

val = phy_read(phydev, stat.reg);
if (val < 0)
ret = UINT64_MAX;
ret = U64_MAX;
else
ret = val;

Expand Down

0 comments on commit 6c3442f

Please sign in to comment.