Skip to content

Commit

Permalink
bcache: check return value of register_shrinker
Browse files Browse the repository at this point in the history
register_shrinker is now __must_check, so check it to kill a warning.
Caller of bch_btree_cache_alloc in super.c appropriately checks return
value so this is fully plumbed through.

This V2 fixes checkpatch warnings and improves the commit description,
as I was too hasty getting the previous version out.

Signed-off-by: Michael Lyle <mlyle@lyle.org>
Reviewed-by: Vojtech Pavlik <vojtech@suse.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Michael Lyle authored and Jens Axboe committed Nov 24, 2017
1 parent e393aa2 commit 6c4ca1e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/md/bcache/btree.c
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,10 @@ int bch_btree_cache_alloc(struct cache_set *c)
c->shrink.scan_objects = bch_mca_scan;
c->shrink.seeks = 4;
c->shrink.batch = c->btree_pages * 2;
register_shrinker(&c->shrink);

if (register_shrinker(&c->shrink))
pr_warn("bcache: %s: could not register shrinker",
__func__);

return 0;
}
Expand Down

0 comments on commit 6c4ca1e

Please sign in to comment.