Skip to content

Commit

Permalink
PCI: altera: Remove redundant platform_get_resource() return value check
Browse files Browse the repository at this point in the history
devm_ioremap_resource() fails gracefully when given a NULL resource
pointer, so we don't need to check separately for failure from
platform_get_resource_byname().  Remove the redundant check.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
  • Loading branch information
Bjorn Helgaas committed Sep 12, 2016
1 parent ce4f1c7 commit 6c8b120
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions drivers/pci/host/pcie-altera-msi.c
Original file line number Diff line number Diff line change
Expand Up @@ -237,11 +237,6 @@ static int altera_msi_probe(struct platform_device *pdev)
msi->pdev = pdev;

res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "csr");
if (!res) {
dev_err(&pdev->dev, "no csr memory resource defined\n");
return -ENODEV;
}

msi->csr_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(msi->csr_base)) {
dev_err(&pdev->dev, "failed to map csr memory\n");
Expand All @@ -250,11 +245,6 @@ static int altera_msi_probe(struct platform_device *pdev)

res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"vector_slave");
if (!res) {
dev_err(&pdev->dev, "no vector_slave memory resource defined\n");
return -ENODEV;
}

msi->vector_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(msi->vector_base)) {
dev_err(&pdev->dev, "failed to map vector_slave memory\n");
Expand Down

0 comments on commit 6c8b120

Please sign in to comment.