Skip to content

Commit

Permalink
ide: add ->dev and ->host_priv fields to struct ide_host
Browse files Browse the repository at this point in the history
* Add 'struct device *dev[2]' and 'void *host_priv' fields
  to struct ide_host.

* Set ->dev[] in ide_host_alloc_all()/ide_setup_pci_device[s]().

* Pass 'void *priv' argument to ide_setup_pci_device[s]()
  and use it to set ->host_priv.

* Set PCI dev's ->driver_data to point to the struct ide_host
  instance if PCI host driver wants to use ->host_priv.

* Rename ide_setup_pci_device[s]() to ide_pci_init_{one,two}().

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz committed Jul 24, 2008
1 parent 8c2eece commit 6cdf6eb
Show file tree
Hide file tree
Showing 33 changed files with 85 additions and 41 deletions.
3 changes: 3 additions & 0 deletions drivers/ide/ide-probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -1604,6 +1604,9 @@ struct ide_host *ide_host_alloc_all(const struct ide_port_info *d,
return NULL;
}

if (hws[0])
host->dev[0] = hws[0]->dev;

return host;
}
EXPORT_SYMBOL_GPL(ide_host_alloc_all);
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/aec62xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ static int __devinit aec62xx_init_one(struct pci_dev *dev, const struct pci_devi
}
}

err = ide_setup_pci_device(dev, &d);
err = ide_pci_init_one(dev, &d, NULL);
if (err)
pci_disable_device(dev);

Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/alim15x3.c
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ static int __devinit alim15x3_init_one(struct pci_dev *dev, const struct pci_dev
if (idx == 0)
d.host_flags |= IDE_HFLAG_CLEAR_SIMPLEX;

return ide_setup_pci_device(dev, &d);
return ide_pci_init_one(dev, &d, NULL);
}


Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/amd74xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ static int __devinit amd74xx_probe(struct pci_dev *dev, const struct pci_device_
d.name, pci_name(dev), dev->revision,
amd_dma[fls(d.udma_mask) - 1]);

return ide_setup_pci_device(dev, &d);
return ide_pci_init_one(dev, &d, NULL);
}

static const struct pci_device_id amd74xx_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/atiixp.c
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ static const struct ide_port_info atiixp_pci_info[] __devinitdata = {

static int __devinit atiixp_init_one(struct pci_dev *dev, const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &atiixp_pci_info[id->driver_data]);
return ide_pci_init_one(dev, &atiixp_pci_info[id->driver_data], NULL);
}

static const struct pci_device_id atiixp_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/cmd64x.c
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ static int __devinit cmd64x_init_one(struct pci_dev *dev, const struct pci_devic
}
}

return ide_setup_pci_device(dev, &d);
return ide_pci_init_one(dev, &d, NULL);
}

static const struct pci_device_id cmd64x_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/cs5530.c
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ static const struct ide_port_info cs5530_chipset __devinitdata = {

static int __devinit cs5530_init_one(struct pci_dev *dev, const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &cs5530_chipset);
return ide_pci_init_one(dev, &cs5530_chipset, NULL);
}

static const struct pci_device_id cs5530_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/cs5535.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ static const struct ide_port_info cs5535_chipset __devinitdata = {
static int __devinit cs5535_init_one(struct pci_dev *dev,
const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &cs5535_chipset);
return ide_pci_init_one(dev, &cs5535_chipset, NULL);
}

static const struct pci_device_id cs5535_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/cy82c693.c
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ static int __devinit cy82c693_init_one(struct pci_dev *dev, const struct pci_dev
if ((dev->class >> 8) == PCI_CLASS_STORAGE_IDE &&
PCI_FUNC(dev->devfn) == 1) {
dev2 = pci_get_slot(dev->bus, dev->devfn + 1);
ret = ide_setup_pci_devices(dev, dev2, &cy82c693_chipset);
ret = ide_pci_init_two(dev, dev2, &cy82c693_chipset, NULL);
/* We leak pci refs here but thats ok - we can't be unloaded */
}
return ret;
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ static int __devinit generic_init_one(struct pci_dev *dev, const struct pci_devi
goto out;
}
}
ret = ide_setup_pci_device(dev, d);
ret = ide_pci_init_one(dev, d, NULL);
out:
return ret;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/hpt34x.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ static int __devinit hpt34x_init_one(struct pci_dev *dev, const struct pci_devic

d = &hpt34x_chipsets[(pcicmd & PCI_COMMAND_MEMORY) ? 1 : 0];

return ide_setup_pci_device(dev, d);
return ide_pci_init_one(dev, d, NULL);
}

static const struct pci_device_id hpt34x_pci_tbl[] = {
Expand Down
4 changes: 2 additions & 2 deletions drivers/ide/pci/hpt366.c
Original file line number Diff line number Diff line change
Expand Up @@ -1608,13 +1608,13 @@ static int __devinit hpt366_init_one(struct pci_dev *dev, const struct pci_devic
d.host_flags &= ~IDE_HFLAG_NON_BOOTABLE;
}

ret = ide_setup_pci_devices(dev, dev2, &d);
ret = ide_pci_init_two(dev, dev2, &d, NULL);
if (ret < 0)
pci_dev_put(dev2);
return ret;
}

return ide_setup_pci_device(dev, &d);
return ide_pci_init_one(dev, &d, NULL);
}

static const struct pci_device_id hpt366_pci_tbl[] __devinitconst = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/it8213.c
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ static const struct ide_port_info it8213_chipsets[] __devinitdata = {

static int __devinit it8213_init_one(struct pci_dev *dev, const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &it8213_chipsets[id->driver_data]);
return ide_pci_init_one(dev, &it8213_chipsets[id->driver_data], NULL);
}

static const struct pci_device_id it8213_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/it821x.c
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,7 @@ static int __devinit it821x_init_one(struct pci_dev *dev, const struct pci_devic

pci_set_drvdata(dev, itdevs);

return ide_setup_pci_device(dev, &it821x_chipsets[id->driver_data]);
return ide_pci_init_one(dev, &it821x_chipsets[id->driver_data], NULL);
}

static const struct pci_device_id it821x_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/jmicron.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ static const struct ide_port_info jmicron_chipset __devinitdata = {

static int __devinit jmicron_init_one(struct pci_dev *dev, const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &jmicron_chipset);
return ide_pci_init_one(dev, &jmicron_chipset, NULL);
}

/* All JMB PATA controllers have and will continue to have the same
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/ns87415.c
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ static int __devinit ns87415_init_one(struct pci_dev *dev, const struct pci_devi
d.tp_ops = &superio_tp_ops;
}
#endif
return ide_setup_pci_device(dev, &d);
return ide_pci_init_one(dev, &d, NULL);
}

static const struct pci_device_id ns87415_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/opti621.c
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ static const struct ide_port_info opti621_chipset __devinitdata = {

static int __devinit opti621_init_one(struct pci_dev *dev, const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &opti621_chipset);
return ide_pci_init_one(dev, &opti621_chipset, NULL);
}

static const struct pci_device_id opti621_pci_tbl[] = {
Expand Down
4 changes: 2 additions & 2 deletions drivers/ide/pci/pdc202xx_new.c
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ static int __devinit pdc202new_init_one(struct pci_dev *dev, const struct pci_de
dev2 = pdc20270_get_dev2(dev);

if (dev2) {
int ret = ide_setup_pci_devices(dev, dev2, d);
int ret = ide_pci_init_two(dev, dev2, d, NULL);
if (ret < 0)
pci_dev_put(dev2);
return ret;
Expand All @@ -540,7 +540,7 @@ static int __devinit pdc202new_init_one(struct pci_dev *dev, const struct pci_de
return -ENODEV;
}

return ide_setup_pci_device(dev, d);
return ide_pci_init_one(dev, d, NULL);
}

static const struct pci_device_id pdc202new_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/pdc202xx_old.c
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ static int __devinit pdc202xx_init_one(struct pci_dev *dev, const struct pci_dev
}
}

return ide_setup_pci_device(dev, d);
return ide_pci_init_one(dev, d, NULL);
}

static const struct pci_device_id pdc202xx_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/piix.c
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ static const struct ide_port_info piix_pci_info[] __devinitdata = {

static int __devinit piix_init_one(struct pci_dev *dev, const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &piix_pci_info[id->driver_data]);
return ide_pci_init_one(dev, &piix_pci_info[id->driver_data], NULL);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/rz1000.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ static const struct ide_port_info rz1000_chipset __devinitdata = {

static int __devinit rz1000_init_one(struct pci_dev *dev, const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &rz1000_chipset);
return ide_pci_init_one(dev, &rz1000_chipset, NULL);
}

static const struct pci_device_id rz1000_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/sc1200.c
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ static const struct ide_port_info sc1200_chipset __devinitdata = {

static int __devinit sc1200_init_one(struct pci_dev *dev, const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &sc1200_chipset);
return ide_pci_init_one(dev, &sc1200_chipset, NULL);
}

static const struct pci_device_id sc1200_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/serverworks.c
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ static int __devinit svwks_init_one(struct pci_dev *dev, const struct pci_device
d.host_flags &= ~IDE_HFLAG_SINGLE;
}

return ide_setup_pci_device(dev, &d);
return ide_pci_init_one(dev, &d, NULL);
}

static const struct pci_device_id svwks_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/siimage.c
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ static int __devinit siimage_init_one(struct pci_dev *dev,
d.host_flags |= IDE_HFLAG_NO_ATAPI_DMA;
}

return ide_setup_pci_device(dev, &d);
return ide_pci_init_one(dev, &d, NULL);
}

static const struct pci_device_id siimage_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/sis5513.c
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ static int __devinit sis5513_init_one(struct pci_dev *dev, const struct pci_devi

d.udma_mask = udma_rates[chipset_family];

return ide_setup_pci_device(dev, &d);
return ide_pci_init_one(dev, &d, NULL);
}

static const struct pci_device_id sis5513_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/sl82c105.c
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ static int __devinit sl82c105_init_one(struct pci_dev *dev, const struct pci_dev
d.host_flags &= ~IDE_HFLAG_SERIALIZE_DMA;
}

return ide_setup_pci_device(dev, &d);
return ide_pci_init_one(dev, &d, NULL);
}

static const struct pci_device_id sl82c105_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/slc90e66.c
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ static const struct ide_port_info slc90e66_chipset __devinitdata = {

static int __devinit slc90e66_init_one(struct pci_dev *dev, const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &slc90e66_chipset);
return ide_pci_init_one(dev, &slc90e66_chipset, NULL);
}

static const struct pci_device_id slc90e66_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/tc86c001.c
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ static const struct ide_port_info tc86c001_chipset __devinitdata = {
static int __devinit tc86c001_init_one(struct pci_dev *dev,
const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &tc86c001_chipset);
return ide_pci_init_one(dev, &tc86c001_chipset, NULL);
}

static const struct pci_device_id tc86c001_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/triflex.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ static const struct ide_port_info triflex_device __devinitdata = {
static int __devinit triflex_init_one(struct pci_dev *dev,
const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &triflex_device);
return ide_pci_init_one(dev, &triflex_device, NULL);
}

static const struct pci_device_id triflex_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/trm290.c
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ static const struct ide_port_info trm290_chipset __devinitdata = {

static int __devinit trm290_init_one(struct pci_dev *dev, const struct pci_device_id *id)
{
return ide_setup_pci_device(dev, &trm290_chipset);
return ide_pci_init_one(dev, &trm290_chipset, NULL);
}

static const struct pci_device_id trm290_pci_tbl[] = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/pci/via82cxxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ static int __devinit via_init_one(struct pci_dev *dev, const struct pci_device_i

d.udma_mask = via_config->udma_mask;

return ide_setup_pci_device(dev, &d);
return ide_pci_init_one(dev, &d, NULL);
}

static const struct pci_device_id via_pci_tbl[] = {
Expand Down
52 changes: 45 additions & 7 deletions drivers/ide/setup-pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -525,8 +525,10 @@ static int do_ide_setup_pci_device(struct pci_dev *dev,
return ret;
}

int ide_setup_pci_device(struct pci_dev *dev, const struct ide_port_info *d)
int ide_pci_init_one(struct pci_dev *dev, const struct ide_port_info *d,
void *priv)
{
struct ide_host *host;
hw_regs_t hw[4], *hws[] = { NULL, NULL, NULL, NULL };
int ret;

Expand All @@ -536,23 +538,39 @@ int ide_setup_pci_device(struct pci_dev *dev, const struct ide_port_info *d)

ide_pci_setup_ports(dev, d, 0, &hw[0], &hws[0]);

host = ide_host_alloc(d, hws);
if (host == NULL) {
ret = -ENOMEM;
goto out;
}

host->dev[0] = &dev->dev;

host->host_priv = priv;

if (priv)
pci_set_drvdata(dev, host);

ret = do_ide_setup_pci_device(dev, d, 1);
if (ret < 0)
goto out;

/* fixup IRQ */
hw[1].irq = hw[0].irq = ret;

ret = ide_host_add(d, hws, NULL);
ret = ide_host_register(host, d, hws);
if (ret)
ide_host_free(host);
out:
return ret;
}
EXPORT_SYMBOL_GPL(ide_setup_pci_device);
EXPORT_SYMBOL_GPL(ide_pci_init_one);

int ide_setup_pci_devices(struct pci_dev *dev1, struct pci_dev *dev2,
const struct ide_port_info *d)
int ide_pci_init_two(struct pci_dev *dev1, struct pci_dev *dev2,
const struct ide_port_info *d, void *priv)
{
struct pci_dev *pdev[] = { dev1, dev2 };
struct ide_host *host;
int ret, i;
hw_regs_t hw[4], *hws[] = { NULL, NULL, NULL, NULL };

Expand All @@ -562,7 +580,25 @@ int ide_setup_pci_devices(struct pci_dev *dev1, struct pci_dev *dev2,
goto out;

ide_pci_setup_ports(pdev[i], d, 0, &hw[i*2], &hws[i*2]);
}

host = ide_host_alloc(d, hws);
if (host == NULL) {
ret = -ENOMEM;
goto out;
}

host->dev[0] = &dev1->dev;
host->dev[1] = &dev2->dev;

host->host_priv = priv;

if (priv) {
pci_set_drvdata(pdev[0], host);
pci_set_drvdata(pdev[1], host);
}

for (i = 0; i < 2; i++) {
ret = do_ide_setup_pci_device(pdev[i], d, !i);

/*
Expand All @@ -576,8 +612,10 @@ int ide_setup_pci_devices(struct pci_dev *dev1, struct pci_dev *dev2,
hw[i*2 + 1].irq = hw[i*2].irq = ret;
}

ret = ide_host_add(d, hws, NULL);
ret = ide_host_register(host, d, hws);
if (ret)
ide_host_free(host);
out:
return ret;
}
EXPORT_SYMBOL_GPL(ide_setup_pci_devices);
EXPORT_SYMBOL_GPL(ide_pci_init_two);
Loading

0 comments on commit 6cdf6eb

Please sign in to comment.