Skip to content

Commit

Permalink
pata_sc1200: Fix crash on boot
Browse files Browse the repository at this point in the history
The SC1200 needs a NULL terminator or it may cause a crash on boot.

Bug #14227

Also correct a bogus comment as the driver had serializing added so can run
dual port.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Alan Cox authored and Jeff Garzik committed Oct 16, 2009
1 parent f4b31db commit 6d4f950
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/ata/pata_sc1200.c
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,7 @@ static int sc1200_init_one(struct pci_dev *dev, const struct pci_device_id *id)
.udma_mask = ATA_UDMA2,
.port_ops = &sc1200_port_ops
};
/* Can't enable port 2 yet, see top comments */
const struct ata_port_info *ppi[] = { &info, };
const struct ata_port_info *ppi[] = { &info, NULL };

return ata_pci_sff_init_one(dev, ppi, &sc1200_sht, NULL);
}
Expand Down

0 comments on commit 6d4f950

Please sign in to comment.