Skip to content

Commit

Permalink
jbd2: Drop unnecessary branch from jbd2_journal_forget()
Browse files Browse the repository at this point in the history
We have cleared both dirty & jbddirty bits from the bh. So there's no
difference between bforget() and brelse(). Thus there's no point jumping
to no_jbd branch.

Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20190809124233.13277-5-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
  • Loading branch information
Jan Kara authored and Theodore Ts'o committed Oct 21, 2019
1 parent 93108eb commit 6d69843
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions fs/jbd2/transaction.c
Original file line number Diff line number Diff line change
Expand Up @@ -1599,10 +1599,6 @@ int jbd2_journal_forget (handle_t *handle, struct buffer_head *bh)
} else {
__jbd2_journal_unfile_buffer(jh);
jbd2_journal_put_journal_head(jh);
if (!buffer_jbd(bh)) {
spin_unlock(&journal->j_list_lock);
goto not_jbd;
}
}
spin_unlock(&journal->j_list_lock);
} else if (jh->b_transaction) {
Expand Down

0 comments on commit 6d69843

Please sign in to comment.