Skip to content

Commit

Permalink
HID: ignore absolute values which don't fit between logical min and max
Browse files Browse the repository at this point in the history
Linux should ignore values outside logical min/max range, as they are not
meaningful. This is what at least some of other OSes do, and it also makes
sense (currently the value gets misinterpreted larger up the stack).

Reported-by: Denilson Figueiredo de Sá <denilsonsa@gmail.com>
Tested-by: Denilson Figueiredo de Sá <denilsonsa@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Jiri Kosina committed Nov 16, 2011
1 parent e46e927 commit 6da7066
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions drivers/hid/hid-input.c
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,13 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
return;
}

/* Ignore absolute values that are out of bounds */
if ((usage->type == EV_ABS && (value < field->logical_minimum ||
value > field->logical_maximum))) {
dbg_hid("Ignoring out-of-range value %x\n", value);
return;
}

/* report the usage code as scancode if the key status has changed */
if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value)
input_event(input, EV_MSC, MSC_SCAN, usage->hid);
Expand Down

0 comments on commit 6da7066

Please sign in to comment.