Skip to content

Commit

Permalink
xen-netback: add reference from xenvif to backend_info to facilitate …
Browse files Browse the repository at this point in the history
…coredump analysis

During coredump analysis, it is not easy to obtain the address of
backend_info in xen-netback.

So far there are two ways to obtain backend_info:

1. Do what xenbus_device_find() does for vmcore to find the xenbus_device
and then derive it from dev_get_drvdata().

2. Extract backend_info from callstack of xenwatch (e.g., netback_remove()
or frontend_changed()).

This patch adds a reference from xenvif to backend_info so that it would be
much more easier to obtain backend_info during coredump analysis.

Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dongli Zhang authored and David S. Miller committed Apr 12, 2019
1 parent 8af9f72 commit 6dc400a
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 16 deletions.
18 changes: 18 additions & 0 deletions drivers/net/xen-netback/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,22 @@ struct xenvif_hash {
struct xenvif_hash_cache cache;
};

struct backend_info {
struct xenbus_device *dev;
struct xenvif *vif;

/* This is the state that will be reflected in xenstore when any
* active hotplug script completes.
*/
enum xenbus_state state;

enum xenbus_state frontend_state;
struct xenbus_watch hotplug_status_watch;
u8 have_hotplug_status_watch:1;

const char *hotplug_script;
};

struct xenvif {
/* Unique identifier for this interface. */
domid_t domid;
Expand Down Expand Up @@ -283,6 +299,8 @@ struct xenvif {
struct xenbus_watch credit_watch;
struct xenbus_watch mcast_ctrl_watch;

struct backend_info *be;

spinlock_t lock;

#ifdef CONFIG_DEBUG_FS
Expand Down
17 changes: 1 addition & 16 deletions drivers/net/xen-netback/xenbus.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,6 @@
#include <linux/vmalloc.h>
#include <linux/rtnetlink.h>

struct backend_info {
struct xenbus_device *dev;
struct xenvif *vif;

/* This is the state that will be reflected in xenstore when any
* active hotplug script completes.
*/
enum xenbus_state state;

enum xenbus_state frontend_state;
struct xenbus_watch hotplug_status_watch;
u8 have_hotplug_status_watch:1;

const char *hotplug_script;
};

static int connect_data_rings(struct backend_info *be,
struct xenvif_queue *queue);
static void connect(struct backend_info *be);
Expand Down Expand Up @@ -472,6 +456,7 @@ static int backend_create_xenvif(struct backend_info *be)
return err;
}
be->vif = vif;
vif->be = be;

kobject_uevent(&dev->dev.kobj, KOBJ_ONLINE);
return 0;
Expand Down

0 comments on commit 6dc400a

Please sign in to comment.