Skip to content

Commit

Permalink
tracing: Remove redundant unread variable ret
Browse files Browse the repository at this point in the history
Integer ret is being assigned but never used and hence it is
redundant. Remove it, fixes clang warning:

trace_events_hist.c:1077:3: warning: Value stored to 'ret' is never read

Link: http://lkml.kernel.org/r/20170823112309.19383-1-colin.king@canonical.com

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
  • Loading branch information
Colin Ian King authored and Steven Rostedt (VMware) committed Oct 4, 2017
1 parent d8c4dee commit 6e7a239
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions kernel/trace/trace_events_hist.c
Original file line number Diff line number Diff line change
Expand Up @@ -1062,7 +1062,7 @@ static void hist_trigger_show(struct seq_file *m,
struct event_trigger_data *data, int n)
{
struct hist_trigger_data *hist_data;
int n_entries, ret = 0;
int n_entries;

if (n > 0)
seq_puts(m, "\n\n");
Expand All @@ -1073,10 +1073,8 @@ static void hist_trigger_show(struct seq_file *m,

hist_data = data->private_data;
n_entries = print_entries(m, hist_data);
if (n_entries < 0) {
ret = n_entries;
if (n_entries < 0)
n_entries = 0;
}

seq_printf(m, "\nTotals:\n Hits: %llu\n Entries: %u\n Dropped: %llu\n",
(u64)atomic64_read(&hist_data->map->hits),
Expand Down

0 comments on commit 6e7a239

Please sign in to comment.