Skip to content

Commit

Permalink
ibmvnic: Remove duplicate memory barriers in tx
Browse files Browse the repository at this point in the history
send_subcrq_[in]direct() already has a dma memory barrier.
Remove the earlier one.

Signed-off-by: Nick Child <nnac123@linux.ibm.com>
Link: https://patch.msgid.link/20240807211809.1259563-5-nnac123@linux.ibm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Nick Child authored and Jakub Kicinski committed Aug 10, 2024
1 parent d95f749 commit 6e7a575
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/net/ethernet/ibm/ibmvnic.c
Original file line number Diff line number Diff line change
Expand Up @@ -2459,9 +2459,6 @@ static netdev_tx_t ibmvnic_xmit(struct sk_buff *skb, struct net_device *netdev)
skb_copy_from_linear_data(skb, dst, skb->len);
}

/* post changes to long_term_buff *dst before VIOS accessing it */
dma_wmb();

tx_pool->consumer_index =
(tx_pool->consumer_index + 1) % tx_pool->num_buffers;

Expand Down

0 comments on commit 6e7a575

Please sign in to comment.