-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
kunit: tool: add Python wrappers for running KUnit tests
The ultimate goal is to create minimal isolated test binaries; in the meantime we are using UML to provide the infrastructure to run tests, so define an abstract way to configure and run tests that allow us to change the context in which tests are built without affecting the user. This also makes pretty and dynamic error reporting, and a lot of other nice features easier. kunit_config.py: - parse .config and Kconfig files. kunit_kernel.py: provides helper functions to: - configure the kernel using kunitconfig. - build the kernel with the appropriate configuration. - provide function to invoke the kernel and stream the output back. kunit_parser.py: parses raw logs returned out by kunit_kernel and displays them in a user friendly way. test_data/*: samples of test data for testing kunit.py, kunit_config.py, etc. Signed-off-by: Felix Guo <felixguoxiuping@gmail.com> Signed-off-by: Brendan Higgins <brendanhiggins@google.com> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Logan Gunthorpe <logang@deltatee.com> Reviewed-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
- Loading branch information
Felix Guo
authored and
Shuah Khan
committed
Sep 30, 2019
1 parent
73ba5aa
commit 6ebf586
Showing
12 changed files
with
1,184 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Byte-compiled / optimized / DLL files | ||
__pycache__/ | ||
*.py[cod] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,116 @@ | ||
#!/usr/bin/python3 | ||
# SPDX-License-Identifier: GPL-2.0 | ||
# | ||
# A thin wrapper on top of the KUnit Kernel | ||
# | ||
# Copyright (C) 2019, Google LLC. | ||
# Author: Felix Guo <felixguoxiuping@gmail.com> | ||
# Author: Brendan Higgins <brendanhiggins@google.com> | ||
|
||
import argparse | ||
import sys | ||
import os | ||
import time | ||
|
||
from collections import namedtuple | ||
from enum import Enum, auto | ||
|
||
import kunit_config | ||
import kunit_kernel | ||
import kunit_parser | ||
|
||
KunitResult = namedtuple('KunitResult', ['status','result']) | ||
|
||
KunitRequest = namedtuple('KunitRequest', ['raw_output','timeout', 'jobs', 'build_dir']) | ||
|
||
class KunitStatus(Enum): | ||
SUCCESS = auto() | ||
CONFIG_FAILURE = auto() | ||
BUILD_FAILURE = auto() | ||
TEST_FAILURE = auto() | ||
|
||
def run_tests(linux: kunit_kernel.LinuxSourceTree, | ||
request: KunitRequest) -> KunitResult: | ||
config_start = time.time() | ||
success = linux.build_reconfig(request.build_dir) | ||
config_end = time.time() | ||
if not success: | ||
return KunitResult(KunitStatus.CONFIG_FAILURE, 'could not configure kernel') | ||
|
||
kunit_parser.print_with_timestamp('Building KUnit Kernel ...') | ||
|
||
build_start = time.time() | ||
success = linux.build_um_kernel(request.jobs, request.build_dir) | ||
build_end = time.time() | ||
if not success: | ||
return KunitResult(KunitStatus.BUILD_FAILURE, 'could not build kernel') | ||
|
||
kunit_parser.print_with_timestamp('Starting KUnit Kernel ...') | ||
test_start = time.time() | ||
|
||
test_result = kunit_parser.TestResult(kunit_parser.TestStatus.SUCCESS, | ||
[], | ||
'Tests not Parsed.') | ||
if request.raw_output: | ||
kunit_parser.raw_output( | ||
linux.run_kernel(timeout=request.timeout)) | ||
else: | ||
kunit_output = linux.run_kernel(timeout=request.timeout) | ||
test_result = kunit_parser.parse_run_tests(kunit_output) | ||
test_end = time.time() | ||
|
||
kunit_parser.print_with_timestamp(( | ||
'Elapsed time: %.3fs total, %.3fs configuring, %.3fs ' + | ||
'building, %.3fs running\n') % ( | ||
test_end - config_start, | ||
config_end - config_start, | ||
build_end - build_start, | ||
test_end - test_start)) | ||
|
||
if test_result.status != kunit_parser.TestStatus.SUCCESS: | ||
return KunitResult(KunitStatus.TEST_FAILURE, test_result) | ||
else: | ||
return KunitResult(KunitStatus.SUCCESS, test_result) | ||
|
||
def main(argv, linux): | ||
parser = argparse.ArgumentParser( | ||
description='Helps writing and running KUnit tests.') | ||
subparser = parser.add_subparsers(dest='subcommand') | ||
|
||
run_parser = subparser.add_parser('run', help='Runs KUnit tests.') | ||
run_parser.add_argument('--raw_output', help='don\'t format output from kernel', | ||
action='store_true') | ||
|
||
run_parser.add_argument('--timeout', | ||
help='maximum number of seconds to allow for all tests ' | ||
'to run. This does not include time taken to build the ' | ||
'tests.', | ||
type=int, | ||
default=300, | ||
metavar='timeout') | ||
|
||
run_parser.add_argument('--jobs', | ||
help='As in the make command, "Specifies the number of ' | ||
'jobs (commands) to run simultaneously."', | ||
type=int, default=8, metavar='jobs') | ||
|
||
run_parser.add_argument('--build_dir', | ||
help='As in the make command, it specifies the build ' | ||
'directory.', | ||
type=str, default=None, metavar='build_dir') | ||
|
||
cli_args = parser.parse_args(argv) | ||
|
||
if cli_args.subcommand == 'run': | ||
request = KunitRequest(cli_args.raw_output, | ||
cli_args.timeout, | ||
cli_args.jobs, | ||
cli_args.build_dir) | ||
result = run_tests(linux, request) | ||
if result.status != KunitStatus.SUCCESS: | ||
sys.exit(1) | ||
else: | ||
parser.print_help() | ||
|
||
if __name__ == '__main__': | ||
main(sys.argv[1:], kunit_kernel.LinuxSourceTree()) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
# SPDX-License-Identifier: GPL-2.0 | ||
# | ||
# Builds a .config from a kunitconfig. | ||
# | ||
# Copyright (C) 2019, Google LLC. | ||
# Author: Felix Guo <felixguoxiuping@gmail.com> | ||
# Author: Brendan Higgins <brendanhiggins@google.com> | ||
|
||
import collections | ||
import re | ||
|
||
CONFIG_IS_NOT_SET_PATTERN = r'^# CONFIG_\w+ is not set$' | ||
CONFIG_PATTERN = r'^CONFIG_\w+=\S+$' | ||
|
||
KconfigEntryBase = collections.namedtuple('KconfigEntry', ['raw_entry']) | ||
|
||
|
||
class KconfigEntry(KconfigEntryBase): | ||
|
||
def __str__(self) -> str: | ||
return self.raw_entry | ||
|
||
|
||
class KconfigParseError(Exception): | ||
"""Error parsing Kconfig defconfig or .config.""" | ||
|
||
|
||
class Kconfig(object): | ||
"""Represents defconfig or .config specified using the Kconfig language.""" | ||
|
||
def __init__(self): | ||
self._entries = [] | ||
|
||
def entries(self): | ||
return set(self._entries) | ||
|
||
def add_entry(self, entry: KconfigEntry) -> None: | ||
self._entries.append(entry) | ||
|
||
def is_subset_of(self, other: 'Kconfig') -> bool: | ||
return self.entries().issubset(other.entries()) | ||
|
||
def write_to_file(self, path: str) -> None: | ||
with open(path, 'w') as f: | ||
for entry in self.entries(): | ||
f.write(str(entry) + '\n') | ||
|
||
def parse_from_string(self, blob: str) -> None: | ||
"""Parses a string containing KconfigEntrys and populates this Kconfig.""" | ||
self._entries = [] | ||
is_not_set_matcher = re.compile(CONFIG_IS_NOT_SET_PATTERN) | ||
config_matcher = re.compile(CONFIG_PATTERN) | ||
for line in blob.split('\n'): | ||
line = line.strip() | ||
if not line: | ||
continue | ||
elif config_matcher.match(line) or is_not_set_matcher.match(line): | ||
self._entries.append(KconfigEntry(line)) | ||
elif line[0] == '#': | ||
continue | ||
else: | ||
raise KconfigParseError('Failed to parse: ' + line) | ||
|
||
def read_from_file(self, path: str) -> None: | ||
with open(path, 'r') as f: | ||
self.parse_from_string(f.read()) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,148 @@ | ||
# SPDX-License-Identifier: GPL-2.0 | ||
# | ||
# Runs UML kernel, collects output, and handles errors. | ||
# | ||
# Copyright (C) 2019, Google LLC. | ||
# Author: Felix Guo <felixguoxiuping@gmail.com> | ||
# Author: Brendan Higgins <brendanhiggins@google.com> | ||
|
||
|
||
import logging | ||
import subprocess | ||
import os | ||
|
||
import kunit_config | ||
|
||
KCONFIG_PATH = '.config' | ||
|
||
class ConfigError(Exception): | ||
"""Represents an error trying to configure the Linux kernel.""" | ||
|
||
|
||
class BuildError(Exception): | ||
"""Represents an error trying to build the Linux kernel.""" | ||
|
||
|
||
class LinuxSourceTreeOperations(object): | ||
"""An abstraction over command line operations performed on a source tree.""" | ||
|
||
def make_mrproper(self): | ||
try: | ||
subprocess.check_output(['make', 'mrproper']) | ||
except OSError as e: | ||
raise ConfigError('Could not call make command: ' + e) | ||
except subprocess.CalledProcessError as e: | ||
raise ConfigError(e.output) | ||
|
||
def make_olddefconfig(self, build_dir): | ||
command = ['make', 'ARCH=um', 'olddefconfig'] | ||
if build_dir: | ||
command += ['O=' + build_dir] | ||
try: | ||
subprocess.check_output(command) | ||
except OSError as e: | ||
raise ConfigError('Could not call make command: ' + e) | ||
except subprocess.CalledProcessError as e: | ||
raise ConfigError(e.output) | ||
|
||
def make(self, jobs, build_dir): | ||
command = ['make', 'ARCH=um', '--jobs=' + str(jobs)] | ||
if build_dir: | ||
command += ['O=' + build_dir] | ||
try: | ||
subprocess.check_output(command) | ||
except OSError as e: | ||
raise BuildError('Could not call execute make: ' + e) | ||
except subprocess.CalledProcessError as e: | ||
raise BuildError(e.output) | ||
|
||
def linux_bin(self, params, timeout, build_dir): | ||
"""Runs the Linux UML binary. Must be named 'linux'.""" | ||
linux_bin = './linux' | ||
if build_dir: | ||
linux_bin = os.path.join(build_dir, 'linux') | ||
process = subprocess.Popen( | ||
[linux_bin] + params, | ||
stdin=subprocess.PIPE, | ||
stdout=subprocess.PIPE, | ||
stderr=subprocess.PIPE) | ||
process.wait(timeout=timeout) | ||
return process | ||
|
||
|
||
def get_kconfig_path(build_dir): | ||
kconfig_path = KCONFIG_PATH | ||
if build_dir: | ||
kconfig_path = os.path.join(build_dir, KCONFIG_PATH) | ||
return kconfig_path | ||
|
||
class LinuxSourceTree(object): | ||
"""Represents a Linux kernel source tree with KUnit tests.""" | ||
|
||
def __init__(self): | ||
self._kconfig = kunit_config.Kconfig() | ||
self._kconfig.read_from_file('kunitconfig') | ||
self._ops = LinuxSourceTreeOperations() | ||
|
||
def clean(self): | ||
try: | ||
self._ops.make_mrproper() | ||
except ConfigError as e: | ||
logging.error(e) | ||
return False | ||
return True | ||
|
||
def build_config(self, build_dir): | ||
kconfig_path = get_kconfig_path(build_dir) | ||
if build_dir and not os.path.exists(build_dir): | ||
os.mkdir(build_dir) | ||
self._kconfig.write_to_file(kconfig_path) | ||
try: | ||
self._ops.make_olddefconfig(build_dir) | ||
except ConfigError as e: | ||
logging.error(e) | ||
return False | ||
validated_kconfig = kunit_config.Kconfig() | ||
validated_kconfig.read_from_file(kconfig_path) | ||
if not self._kconfig.is_subset_of(validated_kconfig): | ||
logging.error('Provided Kconfig is not contained in validated .config!') | ||
return False | ||
return True | ||
|
||
def build_reconfig(self, build_dir): | ||
"""Creates a new .config if it is not a subset of the kunitconfig.""" | ||
kconfig_path = get_kconfig_path(build_dir) | ||
if os.path.exists(kconfig_path): | ||
existing_kconfig = kunit_config.Kconfig() | ||
existing_kconfig.read_from_file(kconfig_path) | ||
if not self._kconfig.is_subset_of(existing_kconfig): | ||
print('Regenerating .config ...') | ||
os.remove(kconfig_path) | ||
return self.build_config(build_dir) | ||
else: | ||
return True | ||
else: | ||
print('Generating .config ...') | ||
return self.build_config(build_dir) | ||
|
||
def build_um_kernel(self, jobs, build_dir): | ||
try: | ||
self._ops.make_olddefconfig(build_dir) | ||
self._ops.make(jobs, build_dir) | ||
except (ConfigError, BuildError) as e: | ||
logging.error(e) | ||
return False | ||
used_kconfig = kunit_config.Kconfig() | ||
used_kconfig.read_from_file(get_kconfig_path(build_dir)) | ||
if not self._kconfig.is_subset_of(used_kconfig): | ||
logging.error('Provided Kconfig is not contained in final config!') | ||
return False | ||
return True | ||
|
||
def run_kernel(self, args=[], timeout=None, build_dir=None): | ||
args.extend(['mem=256M']) | ||
process = self._ops.linux_bin(args, timeout, build_dir) | ||
with open('test.log', 'w') as f: | ||
for line in process.stdout: | ||
f.write(line.rstrip().decode('ascii') + '\n') | ||
yield line.rstrip().decode('ascii') |
Oops, something went wrong.