Skip to content

Commit

Permalink
Input: adp5588-keys - drop CONFIG_PM guards
Browse files Browse the repository at this point in the history
To improve compile-time coverage let's drop #ifdef CONFIG_PM guards
and use SIMPLE_DEV_PM_OPS and __maybe_unused attributes and rely on
the linker to drop unused code.

Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Link: https://lore.kernel.org/r/20220528045631.289821-1-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
  • Loading branch information
Dmitry Torokhov committed May 31, 2022
1 parent ba0f321 commit 6ec75b2
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions drivers/input/keyboard/adp5588-keys.c
Original file line number Diff line number Diff line change
Expand Up @@ -612,8 +612,7 @@ static int adp5588_remove(struct i2c_client *client)
return 0;
}

#ifdef CONFIG_PM
static int adp5588_suspend(struct device *dev)
static int __maybe_unused adp5588_suspend(struct device *dev)
{
struct adp5588_kpad *kpad = dev_get_drvdata(dev);
struct i2c_client *client = kpad->client;
Expand All @@ -627,7 +626,7 @@ static int adp5588_suspend(struct device *dev)
return 0;
}

static int adp5588_resume(struct device *dev)
static int __maybe_unused adp5588_resume(struct device *dev)
{
struct adp5588_kpad *kpad = dev_get_drvdata(dev);
struct i2c_client *client = kpad->client;
Expand All @@ -640,11 +639,7 @@ static int adp5588_resume(struct device *dev)
return 0;
}

static const struct dev_pm_ops adp5588_dev_pm_ops = {
.suspend = adp5588_suspend,
.resume = adp5588_resume,
};
#endif
static SIMPLE_DEV_PM_OPS(adp5588_dev_pm_ops, adp5588_suspend, adp5588_resume);

static const struct i2c_device_id adp5588_id[] = {
{ "adp5588-keys", 0 },
Expand All @@ -656,9 +651,7 @@ MODULE_DEVICE_TABLE(i2c, adp5588_id);
static struct i2c_driver adp5588_driver = {
.driver = {
.name = KBUILD_MODNAME,
#ifdef CONFIG_PM
.pm = &adp5588_dev_pm_ops,
#endif
},
.probe = adp5588_probe,
.remove = adp5588_remove,
Expand Down

0 comments on commit 6ec75b2

Please sign in to comment.