Skip to content

Commit

Permalink
ACPI: dock: fix some coding style issues
Browse files Browse the repository at this point in the history
Fix some coding style issues reported by checkpatch.pl, including
following types:

WARNING: Missing a blank line after declarations
ERROR: spaces required around that ':'
WARNING: Statements should start on a tabstop

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Xiaofei Tan authored and Rafael J. Wysocki committed Apr 8, 2021
1 parent d0fb66e commit 6ee4bdc
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/acpi/dock.c
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ static void hotplug_dock_devices(struct dock_station *ds, u32 event)

if (!acpi_device_enumerated(adev)) {
int ret = acpi_bus_scan(adev->handle);

if (ret)
dev_dbg(&adev->dev, "scan error %d\n", -ret);
}
Expand Down Expand Up @@ -502,6 +503,7 @@ static ssize_t flags_show(struct device *dev,
struct device_attribute *attr, char *buf)
{
struct dock_station *dock_station = dev->platform_data;

return snprintf(buf, PAGE_SIZE, "%d\n", dock_station->flags);

}
Expand All @@ -523,7 +525,7 @@ static ssize_t undock_store(struct device *dev, struct device_attribute *attr,
begin_undock(dock_station);
ret = handle_eject_request(dock_station, ACPI_NOTIFY_EJECT_REQUEST);
acpi_scan_lock_release();
return ret ? ret: count;
return ret ? ret : count;
}
static DEVICE_ATTR_WO(undock);

Expand All @@ -535,10 +537,11 @@ static ssize_t uid_show(struct device *dev,
{
unsigned long long lbuf;
struct dock_station *dock_station = dev->platform_data;

acpi_status status = acpi_evaluate_integer(dock_station->handle,
"_UID", NULL, &lbuf);
if (ACPI_FAILURE(status))
return 0;
return 0;

return snprintf(buf, PAGE_SIZE, "%llx\n", lbuf);
}
Expand Down

0 comments on commit 6ee4bdc

Please sign in to comment.