Skip to content

Commit

Permalink
kernel/system_certificate.S: use real contents instead of macro GLOBAL()
Browse files Browse the repository at this point in the history
If a macro is only used within 2 times, and also its contents are
within 2 lines, recommend to expand it to shrink code line.

For our case, the macro is not portable either: some architectures'
assembler may use another character to mark newline in a macro (e.g.
'`' for arc), which will cause issue.

If still want to use macro and let it portable enough, it will also
need include additional header file (e.g "#include <linux/linkage.h>",
although it also need be fixed).


Signed-off-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: David Howells <dhowells@redhat.com>
  • Loading branch information
Chen Gang authored and David Howells committed Oct 30, 2013
1 parent d2b8697 commit 6ef4d2e
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions kernel/system_certificates.S
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
#include <linux/export.h>
#include <linux/init.h>

#define GLOBAL(name) \
.globl VMLINUX_SYMBOL(name); \
VMLINUX_SYMBOL(name):

__INITRODATA

GLOBAL(system_certificate_list)
.globl VMLINUX_SYMBOL(system_certificate_list)
VMLINUX_SYMBOL(system_certificate_list):
.incbin "kernel/x509_certificate_list"
GLOBAL(system_certificate_list_end)
.globl VMLINUX_SYMBOL(system_certificate_list_end)
VMLINUX_SYMBOL(system_certificate_list_end):

0 comments on commit 6ef4d2e

Please sign in to comment.