Skip to content

Commit

Permalink
devlink: don't require setting features before registration
Browse files Browse the repository at this point in the history
Requiring devlink_set_features() to be run before devlink is
registered is overzealous. devlink_set_features() itself is
a leftover from old workarounds which were trying to prevent
initiating reload before probe was complete.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jakub Kicinski authored and David S. Miller committed Jan 6, 2023
1 parent 9053637 commit 6ef8f7d
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions net/devlink/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,6 @@ struct devlink *devlinks_xa_find_get(struct net *net, unsigned long *indexp)
*/
void devlink_set_features(struct devlink *devlink, u64 features)
{
ASSERT_DEVLINK_NOT_REGISTERED(devlink);

WARN_ON(features & DEVLINK_F_RELOAD &&
!devlink_reload_supported(devlink->ops));
devlink->features = features;
Expand Down

0 comments on commit 6ef8f7d

Please sign in to comment.