Skip to content

Commit

Permalink
iommu/amd: Keep track of HPET and IOAPIC device ids
Browse files Browse the repository at this point in the history
The IVRS ACPI table provides information about the IOAPICs
and the HPETs available in the system and which PCI device
ID they use in transactions. Save that information for later
usage in interrupt remapping.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
  • Loading branch information
Joerg Roedel committed Sep 28, 2012
1 parent 979570e commit 6efed63
Show file tree
Hide file tree
Showing 3 changed files with 103 additions and 2 deletions.
3 changes: 3 additions & 0 deletions drivers/iommu/amd_iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ static DEFINE_SPINLOCK(iommu_pd_list_lock);
static LIST_HEAD(dev_data_list);
static DEFINE_SPINLOCK(dev_data_list_lock);

LIST_HEAD(ioapic_map);
LIST_HEAD(hpet_map);

/*
* Domain for untranslated devices - only allocated
* if iommu=pt passed on kernel cmd line.
Expand Down
68 changes: 66 additions & 2 deletions drivers/iommu/amd_iommu_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@
#define IVHD_DEV_ALIAS_RANGE 0x43
#define IVHD_DEV_EXT_SELECT 0x46
#define IVHD_DEV_EXT_SELECT_RANGE 0x47
#define IVHD_DEV_SPECIAL 0x48

#define IVHD_SPECIAL_IOAPIC 1
#define IVHD_SPECIAL_HPET 2

#define IVHD_FLAG_HT_TUN_EN_MASK 0x01
#define IVHD_FLAG_PASSPW_EN_MASK 0x02
Expand Down Expand Up @@ -690,6 +694,31 @@ static void __init set_dev_entry_from_acpi(struct amd_iommu *iommu,
set_iommu_for_device(iommu, devid);
}

static int add_special_device(u8 type, u8 id, u16 devid)
{
struct devid_map *entry;
struct list_head *list;

if (type != IVHD_SPECIAL_IOAPIC && type != IVHD_SPECIAL_HPET)
return -EINVAL;

entry = kzalloc(sizeof(*entry), GFP_KERNEL);
if (!entry)
return -ENOMEM;

entry->id = id;
entry->devid = devid;

if (type == IVHD_SPECIAL_IOAPIC)
list = &ioapic_map;
else
list = &hpet_map;

list_add_tail(&entry->list, list);

return 0;
}

/*
* Reads the device exclusion range from ACPI and initialize IOMMU with
* it
Expand Down Expand Up @@ -717,7 +746,7 @@ static void __init set_device_exclusion_range(u16 devid, struct ivmd_header *m)
* Takes a pointer to an AMD IOMMU entry in the ACPI table and
* initializes the hardware and our data structures with it.
*/
static void __init init_iommu_from_acpi(struct amd_iommu *iommu,
static int __init init_iommu_from_acpi(struct amd_iommu *iommu,
struct ivhd_header *h)
{
u8 *p = (u8 *)h;
Expand Down Expand Up @@ -867,12 +896,43 @@ static void __init init_iommu_from_acpi(struct amd_iommu *iommu,
flags, ext_flags);
}
break;
case IVHD_DEV_SPECIAL: {
u8 handle, type;
const char *var;
u16 devid;
int ret;

handle = e->ext & 0xff;
devid = (e->ext >> 8) & 0xffff;
type = (e->ext >> 24) & 0xff;

if (type == IVHD_SPECIAL_IOAPIC)
var = "IOAPIC";
else if (type == IVHD_SPECIAL_HPET)
var = "HPET";
else
var = "UNKNOWN";

DUMP_printk(" DEV_SPECIAL(%s[%d])\t\tdevid: %02x:%02x.%x\n",
var, (int)handle,
PCI_BUS(devid),
PCI_SLOT(devid),
PCI_FUNC(devid));

set_dev_entry_from_acpi(iommu, devid, e->flags, 0);
ret = add_special_device(type, handle, devid);
if (ret)
return ret;
break;
}
default:
break;
}

p += ivhd_entry_length(p);
}

return 0;
}

/* Initializes the device->iommu mapping for the driver */
Expand Down Expand Up @@ -912,6 +972,8 @@ static void __init free_iommu_all(void)
*/
static int __init init_iommu_one(struct amd_iommu *iommu, struct ivhd_header *h)
{
int ret;

spin_lock_init(&iommu->lock);

/* Add IOMMU to internal data structures */
Expand Down Expand Up @@ -947,7 +1009,9 @@ static int __init init_iommu_one(struct amd_iommu *iommu, struct ivhd_header *h)

iommu->int_enabled = false;

init_iommu_from_acpi(iommu, h);
ret = init_iommu_from_acpi(iommu, h);
if (ret)
return ret;
init_iommu_devices(iommu);

return 0;
Expand Down
34 changes: 34 additions & 0 deletions drivers/iommu/amd_iommu_types.h
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,16 @@ struct amd_iommu {
u32 stored_l2[0x83];
};

struct devid_map {
struct list_head list;
u8 id;
u16 devid;
};

/* Map HPET and IOAPIC ids to the devid used by the IOMMU */
extern struct list_head ioapic_map;
extern struct list_head hpet_map;

/*
* List with all IOMMUs in the system. This list is not locked because it is
* only written and read at driver initialization or suspend time
Expand Down Expand Up @@ -678,6 +688,30 @@ static inline u16 calc_devid(u8 bus, u8 devfn)
return (((u16)bus) << 8) | devfn;
}

static inline int get_ioapic_devid(int id)
{
struct devid_map *entry;

list_for_each_entry(entry, &ioapic_map, list) {
if (entry->id == id)
return entry->devid;
}

return -EINVAL;
}

static inline int get_hpet_devid(int id)
{
struct devid_map *entry;

list_for_each_entry(entry, &hpet_map, list) {
if (entry->id == id)
return entry->devid;
}

return -EINVAL;
}

#ifdef CONFIG_AMD_IOMMU_STATS

struct __iommu_counter {
Expand Down

0 comments on commit 6efed63

Please sign in to comment.