Skip to content

Commit

Permalink
regulator: wm831x_reg_read() failure unnoticed in wm831x_aldo_get_mode()
Browse files Browse the repository at this point in the history
ret should be signed to notice a failure in wm831x_reg_read().

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
  • Loading branch information
Roel Kluin authored and Liam Girdwood committed Dec 17, 2009
1 parent cf9836f commit 6f17c65
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/regulator/wm831x-ldo.c
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ static unsigned int wm831x_aldo_get_mode(struct regulator_dev *rdev)
struct wm831x_ldo *ldo = rdev_get_drvdata(rdev);
struct wm831x *wm831x = ldo->wm831x;
int on_reg = ldo->base + WM831X_LDO_ON_CONTROL;
unsigned int ret;
int ret;

ret = wm831x_reg_read(wm831x, on_reg);
if (ret < 0)
Expand Down

0 comments on commit 6f17c65

Please sign in to comment.