Skip to content

Commit

Permalink
fsnotify: use kmem_cache_zalloc to simplify event initialization
Browse files Browse the repository at this point in the history
fsnotify event initialization is done entry by entry with almost everything
set to either 0 or NULL.  Use kmem_cache_zalloc and only initialize things
that need non-zero initialization.  Also means we don't have to change
initialization entries based on the config options.

Signed-off-by: Eric Paris <eparis@redhat.com>
  • Loading branch information
Eric Paris committed Jul 28, 2010
1 parent f0553af commit 6f3a539
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions fs/notify/notification.c
Original file line number Diff line number Diff line change
Expand Up @@ -314,25 +314,14 @@ void fsnotify_flush_notify(struct fsnotify_group *group)

static void initialize_event(struct fsnotify_event *event)
{
event->holder.event = NULL;
INIT_LIST_HEAD(&event->holder.event_list);
atomic_set(&event->refcnt, 1);

spin_lock_init(&event->lock);

event->path.dentry = NULL;
event->path.mnt = NULL;
event->inode = NULL;
event->data_type = FSNOTIFY_EVENT_NONE;

INIT_LIST_HEAD(&event->private_data_list);

event->to_tell = NULL;

event->file_name = NULL;
event->name_len = 0;

event->sync_cookie = 0;
}

/*
Expand All @@ -353,7 +342,7 @@ struct fsnotify_event *fsnotify_create_event(struct inode *to_tell, __u32 mask,
{
struct fsnotify_event *event;

event = kmem_cache_alloc(fsnotify_event_cachep, gfp);
event = kmem_cache_zalloc(fsnotify_event_cachep, gfp);
if (!event)
return NULL;

Expand Down

0 comments on commit 6f3a539

Please sign in to comment.