Skip to content

Commit

Permalink
thunderbolt: Hide authorized attribute if router does not support PCI…
Browse files Browse the repository at this point in the history
…e tunnels

With USB4 devices PCIe tunneling is optional so for device routers
without PCIe upstream adapter it does not make much sense to expose the
authorized attribute. For this reason hide it if PCIe tunneling is not
supported by the device router.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Mika Westerberg committed Apr 9, 2021
1 parent 2f608ba commit 6f3bade
Showing 1 changed file with 14 additions and 1 deletion.
15 changes: 14 additions & 1 deletion drivers/thunderbolt/switch.c
Original file line number Diff line number Diff line change
Expand Up @@ -1746,6 +1746,18 @@ static struct attribute *switch_attrs[] = {
NULL,
};

static bool has_port(const struct tb_switch *sw, enum tb_port_type type)
{
const struct tb_port *port;

tb_switch_for_each_port(sw, port) {
if (!port->disabled && port->config.type == type)
return true;
}

return false;
}

static umode_t switch_attr_is_visible(struct kobject *kobj,
struct attribute *attr, int n)
{
Expand All @@ -1754,7 +1766,8 @@ static umode_t switch_attr_is_visible(struct kobject *kobj,

if (attr == &dev_attr_authorized.attr) {
if (sw->tb->security_level == TB_SECURITY_NOPCIE ||
sw->tb->security_level == TB_SECURITY_DPONLY)
sw->tb->security_level == TB_SECURITY_DPONLY ||
!has_port(sw, TB_TYPE_PCIE_UP))
return 0;
} else if (attr == &dev_attr_device.attr) {
if (!sw->device)
Expand Down

0 comments on commit 6f3bade

Please sign in to comment.