Skip to content

Commit

Permalink
ag71xx: fix error return code in ag71xx_probe()
Browse files Browse the repository at this point in the history
Fix to return error code -ENOMEM from the dmam_alloc_coherent() error
handling case instead of 0, as done elsewhere in this function.

Fixes: d51b6ce ("net: ethernet: add ag71xx driver")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wei Yongjun authored and David S. Miller committed Jul 19, 2019
1 parent 7d60530 commit 6f5fa8d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/net/ethernet/atheros/ag71xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1725,8 +1725,10 @@ static int ag71xx_probe(struct platform_device *pdev)
ag->stop_desc = dmam_alloc_coherent(&pdev->dev,
sizeof(struct ag71xx_desc),
&ag->stop_desc_dma, GFP_KERNEL);
if (!ag->stop_desc)
if (!ag->stop_desc) {
err = -ENOMEM;
goto err_free;
}

ag->stop_desc->data = 0;
ag->stop_desc->ctrl = 0;
Expand Down

0 comments on commit 6f5fa8d

Please sign in to comment.