Skip to content

Commit

Permalink
ARM: dts: armada-xp: fix Armada XP boards NAND description
Browse files Browse the repository at this point in the history
Commit 3b79919 ("ARM: dts:
armada-370-xp: update NAND node with new bindings") updated some
Marvell Armada DT description to use the new NAND controller bindings,
but did it incorrectly for a number of boards: armada-xp-gp,
armada-xp-db and armada-xp-lenovo-ix4-300d. Due to this, the NAND is
no longer detected on those platforms.

This commit fixes that by properly using the new NAND DT binding. This
commit was runtime-tested on Armada XP GP, the two other platforms are
only compile-tested.

Fixes: 3b79919 ("ARM: dts: armada-370-xp: update NAND node with new bindings")
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
  • Loading branch information
Thomas Petazzoni authored and Gregory CLEMENT committed Feb 19, 2019
1 parent b5f0348 commit 6fc9791
Show file tree
Hide file tree
Showing 3 changed files with 76 additions and 68 deletions.
46 changes: 24 additions & 22 deletions arch/arm/boot/dts/armada-xp-db.dts
Original file line number Diff line number Diff line change
Expand Up @@ -144,30 +144,32 @@
status = "okay";
};

nand@d0000 {
nand-controller@d0000 {
status = "okay";
label = "pxa3xx_nand-0";
num-cs = <1>;
marvell,nand-keep-config;
nand-on-flash-bbt;

partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;

partition@0 {
label = "U-Boot";
reg = <0 0x800000>;
};
partition@800000 {
label = "Linux";
reg = <0x800000 0x800000>;
};
partition@1000000 {
label = "Filesystem";
reg = <0x1000000 0x3f000000>;

nand@0 {
reg = <0>;
label = "pxa3xx_nand-0";
nand-rb = <0>;
nand-on-flash-bbt;

partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;

partition@0 {
label = "U-Boot";
reg = <0 0x800000>;
};
partition@800000 {
label = "Linux";
reg = <0x800000 0x800000>;
};
partition@1000000 {
label = "Filesystem";
reg = <0x1000000 0x3f000000>;
};
};
};
};
Expand Down
13 changes: 8 additions & 5 deletions arch/arm/boot/dts/armada-xp-gp.dts
Original file line number Diff line number Diff line change
Expand Up @@ -160,12 +160,15 @@
status = "okay";
};

nand@d0000 {
nand-controller@d0000 {
status = "okay";
label = "pxa3xx_nand-0";
num-cs = <1>;
marvell,nand-keep-config;
nand-on-flash-bbt;

nand@0 {
reg = <0>;
label = "pxa3xx_nand-0";
nand-rb = <0>;
nand-on-flash-bbt;
};
};
};

Expand Down
85 changes: 44 additions & 41 deletions arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts
Original file line number Diff line number Diff line change
Expand Up @@ -81,49 +81,52 @@

};

nand@d0000 {
nand-controller@d0000 {
status = "okay";
label = "pxa3xx_nand-0";
num-cs = <1>;
marvell,nand-keep-config;
nand-on-flash-bbt;

partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;

partition@0 {
label = "u-boot";
reg = <0x00000000 0x000e0000>;
read-only;
};

partition@e0000 {
label = "u-boot-env";
reg = <0x000e0000 0x00020000>;
read-only;
};

partition@100000 {
label = "u-boot-env2";
reg = <0x00100000 0x00020000>;
read-only;
};

partition@120000 {
label = "zImage";
reg = <0x00120000 0x00400000>;
};

partition@520000 {
label = "initrd";
reg = <0x00520000 0x00400000>;
};

partition@e00000 {
label = "boot";
reg = <0x00e00000 0x3f200000>;
nand@0 {
reg = <0>;
label = "pxa3xx_nand-0";
nand-rb = <0>;
nand-on-flash-bbt;

partitions {
compatible = "fixed-partitions";
#address-cells = <1>;
#size-cells = <1>;

partition@0 {
label = "u-boot";
reg = <0x00000000 0x000e0000>;
read-only;
};

partition@e0000 {
label = "u-boot-env";
reg = <0x000e0000 0x00020000>;
read-only;
};

partition@100000 {
label = "u-boot-env2";
reg = <0x00100000 0x00020000>;
read-only;
};

partition@120000 {
label = "zImage";
reg = <0x00120000 0x00400000>;
};

partition@520000 {
label = "initrd";
reg = <0x00520000 0x00400000>;
};

partition@e00000 {
label = "boot";
reg = <0x00e00000 0x3f200000>;
};
};
};
};
Expand Down

0 comments on commit 6fc9791

Please sign in to comment.