Skip to content

Commit

Permalink
r8169: fix runtime suspend
Browse files Browse the repository at this point in the history
When runtime-suspending we configure WoL w/o touching saved_wolopts.
If saved_wolopts == 0 we would power down the PHY in this case what's
wrong. Therefore we have to check the actual chip WoL settings here.

Fixes: 433f9d0 ("r8169: improve saved_wolopts handling")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Heiner Kallweit authored and David S. Miller committed Jul 5, 2018
1 parent a4ca8b7 commit 6fcf9b1
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions drivers/net/ethernet/realtek/r8169.c
Original file line number Diff line number Diff line change
Expand Up @@ -1534,12 +1534,6 @@ static void rtl8169_check_link_status(struct net_device *dev,

#define WAKE_ANY (WAKE_PHY | WAKE_MAGIC | WAKE_UCAST | WAKE_BCAST | WAKE_MCAST)

/* Currently we only enable WoL if explicitly told by userspace to circumvent
* issues on certain platforms, see commit bde135a672bf ("r8169: only enable
* PCI wakeups when WOL is active"). Let's keep __rtl8169_get_wol() for the
* case that we want to respect BIOS settings again.
*/
#if 0
static u32 __rtl8169_get_wol(struct rtl8169_private *tp)
{
u8 options;
Expand Down Expand Up @@ -1574,7 +1568,6 @@ static u32 __rtl8169_get_wol(struct rtl8169_private *tp)

return wolopts;
}
#endif

static void rtl8169_get_wol(struct net_device *dev, struct ethtool_wolinfo *wol)
{
Expand Down Expand Up @@ -4470,7 +4463,7 @@ static void rtl_wol_suspend_quirk(struct rtl8169_private *tp)

static bool rtl_wol_pll_power_down(struct rtl8169_private *tp)
{
if (!netif_running(tp->dev) || !tp->saved_wolopts)
if (!netif_running(tp->dev) || !__rtl8169_get_wol(tp))
return false;

rtl_speed_down(tp);
Expand Down

0 comments on commit 6fcf9b1

Please sign in to comment.