Skip to content

Commit

Permalink
qed: remove pointless call to devlink_param_driverinit_value_set()
Browse files Browse the repository at this point in the history
devlink_param_driverinit_value_set() call makes sense only for "
driverinit" params. However here, the param is "runtime".
devlink_param_driverinit_value_set() returns -EOPNOTSUPP in such case
and does not do anything. So remove the pointless call to
devlink_param_driverinit_value_set() entirely.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jiri Pirko authored and David S. Miller committed Jan 27, 2023
1 parent 2fc631b commit 6fd6eda
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/net/ethernet/qlogic/qed/qed_devlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ static const struct devlink_ops qed_dl_ops = {

struct devlink *qed_devlink_register(struct qed_dev *cdev)
{
union devlink_param_value value;
struct qed_devlink *qdevlink;
struct devlink *dl;
int rc;
Expand All @@ -216,11 +215,6 @@ struct devlink *qed_devlink_register(struct qed_dev *cdev)
if (rc)
goto err_unregister;

value.vbool = false;
devlink_param_driverinit_value_set(dl,
QED_DEVLINK_PARAM_ID_IWARP_CMT,
value);

cdev->iwarp_cmt = false;

qed_fw_reporters_create(dl);
Expand Down

0 comments on commit 6fd6eda

Please sign in to comment.