Skip to content

Commit

Permalink
USB: serial: ark3116: use port device for info and error messages
Browse files Browse the repository at this point in the history
Use the port device rather than usb device in info and error messages.

This makes sure that driver and tty port is included in the messages,
while also making them more uniform.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
  • Loading branch information
Johan Hovold committed Jan 31, 2017
1 parent 41a2af9 commit 6fdb7b0
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions drivers/usb/serial/ark3116.c
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,8 @@ static int ark3116_port_probe(struct usb_serial_port *port)
if (priv->irda)
ark3116_write_reg(serial, 0x9, 0);

dev_info(&serial->dev->dev,
"%s using %s mode\n",
KBUILD_MODNAME,
priv->irda ? "IrDA" : "RS232");
dev_info(&port->dev, "using %s mode\n", priv->irda ? "IrDA" : "RS232");

return 0;
}

Expand Down Expand Up @@ -326,9 +324,8 @@ static void ark3116_set_termios(struct tty_struct *tty,

/* check for software flow control */
if (I_IXOFF(tty) || I_IXON(tty)) {
dev_warn(&serial->dev->dev,
"%s: don't know how to do software flow control\n",
KBUILD_MODNAME);
dev_warn(&port->dev,
"software flow control not implemented\n");
}

/* Don't rewrite B0 */
Expand Down Expand Up @@ -616,9 +613,8 @@ static void ark3116_read_int_callback(struct urb *urb)

result = usb_submit_urb(urb, GFP_ATOMIC);
if (result)
dev_err(&urb->dev->dev,
"%s - Error %d submitting interrupt urb\n",
__func__, result);
dev_err(&port->dev, "failed to resubmit interrupt urb: %d\n",
result);
}


Expand Down

0 comments on commit 6fdb7b0

Please sign in to comment.