Skip to content

Commit

Permalink
fbdev: xilinxfb: Make xilinxfb_release() return void
Browse files Browse the repository at this point in the history
The function xilinxfb_release() returns zero unconditionally. Make it
return void. There is no semantic change, the only effect is that it
becomes obvious that the driver's .remove() callback always returns zero.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Helge Deller <deller@gmx.de>
  • Loading branch information
Uwe Kleine-König authored and Helge Deller committed Oct 20, 2022
1 parent a4f7fcd commit 7028159
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/video/fbdev/xilinxfb.c
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ static int xilinxfb_assign(struct platform_device *pdev,
return rc;
}

static int xilinxfb_release(struct device *dev)
static void xilinxfb_release(struct device *dev)
{
struct xilinxfb_drvdata *drvdata = dev_get_drvdata(dev);

Expand All @@ -402,8 +402,6 @@ static int xilinxfb_release(struct device *dev)
if (!(drvdata->flags & BUS_ACCESS_FLAG))
dcr_unmap(drvdata->dcr_host, drvdata->dcr_len);
#endif

return 0;
}

/* ---------------------------------------------------------------------
Expand Down Expand Up @@ -480,7 +478,9 @@ static int xilinxfb_of_probe(struct platform_device *pdev)

static int xilinxfb_of_remove(struct platform_device *op)
{
return xilinxfb_release(&op->dev);
xilinxfb_release(&op->dev);

return 0;
}

/* Match table for of_platform binding */
Expand Down

0 comments on commit 7028159

Please sign in to comment.