Skip to content

Commit

Permalink
sata_uli: hardreset is broken
Browse files Browse the repository at this point in the history
sata_uli can't do hardresets reliably and lock up.  This went
unnoticed till now as softreset was the default and hardreset was only
used after softreset failed.

Reported by Christian Casteyde in bz#10860.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Christian Casteyde <casteyde.christian@free.fr>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Tejun Heo authored and Jeff Garzik committed Jun 27, 2008
1 parent 543cf4c commit 70a3143
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/ata/sata_uli.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ static struct ata_port_operations uli_ops = {
.inherits = &ata_bmdma_port_ops,
.scr_read = uli_scr_read,
.scr_write = uli_scr_write,
.hardreset = ATA_OP_NULL,
};

static const struct ata_port_info uli_port_info = {
Expand Down

0 comments on commit 70a3143

Please sign in to comment.