Skip to content

Commit

Permalink
serial: sh-sci: Remove BREAK/FRAME/PARITY/OVERRUN printouts
Browse files Browse the repository at this point in the history
Update the SCIF serial driver to remove printouts for break, frame, parity
and overrun errors. This reduces the amount of console printouts generated
by the defconfig kernel on R-Car Gen3 for certain use cases. To retrieve
more information about such errors the user may inspect counters. Also these
errors are fed into the TTY layer for further application specific handling.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
Link: https://lore.kernel.org/r/163884254093.18109.2982470198301927679.sendpatchset@octo
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Magnus Damm authored and Greg Kroah-Hartman committed Dec 20, 2021
1 parent 46dacba commit 712fe4c
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions drivers/tty/serial/sh-sci.c
Original file line number Diff line number Diff line change
Expand Up @@ -896,11 +896,9 @@ static void sci_receive_chars(struct uart_port *port)
if (status & SCxSR_FER(port)) {
flag = TTY_FRAME;
port->icount.frame++;
dev_notice(port->dev, "frame error\n");
} else if (status & SCxSR_PER(port)) {
flag = TTY_PARITY;
port->icount.parity++;
dev_notice(port->dev, "parity error\n");
} else
flag = TTY_NORMAL;

Expand Down Expand Up @@ -940,8 +938,6 @@ static int sci_handle_errors(struct uart_port *port)
/* overrun error */
if (tty_insert_flip_char(tport, 0, TTY_OVERRUN))
copied++;

dev_notice(port->dev, "overrun error\n");
}

if (status & SCxSR_FER(port)) {
Expand All @@ -950,8 +946,6 @@ static int sci_handle_errors(struct uart_port *port)

if (tty_insert_flip_char(tport, 0, TTY_FRAME))
copied++;

dev_notice(port->dev, "frame error\n");
}

if (status & SCxSR_PER(port)) {
Expand All @@ -960,8 +954,6 @@ static int sci_handle_errors(struct uart_port *port)

if (tty_insert_flip_char(tport, 0, TTY_PARITY))
copied++;

dev_notice(port->dev, "parity error\n");
}

if (copied)
Expand Down Expand Up @@ -991,8 +983,6 @@ static int sci_handle_fifo_overrun(struct uart_port *port)

tty_insert_flip_char(tport, 0, TTY_OVERRUN);
tty_flip_buffer_push(tport);

dev_dbg(port->dev, "overrun error\n");
copied++;
}

Expand All @@ -1014,8 +1004,6 @@ static int sci_handle_breaks(struct uart_port *port)
/* Notify of BREAK */
if (tty_insert_flip_char(tport, 0, TTY_BREAK))
copied++;

dev_dbg(port->dev, "BREAK detected\n");
}

if (copied)
Expand Down

0 comments on commit 712fe4c

Please sign in to comment.