Skip to content

Commit

Permalink
irqchip: bcm7120-l2: Fix error handling of irq_of_parse_and_map
Browse files Browse the repository at this point in the history
Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.

Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Kevin Cernekee <cernekee@gmail.com>
Link: https://lkml.kernel.org/r/20141114221614.GA37395@dtor-ws
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
  • Loading branch information
Dmitry Torokhov authored and Jason Cooper committed Nov 26, 2014
1 parent 45977fe commit 714710e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/irqchip/irq-bcm7120-l2.c
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ static int bcm7120_l2_intc_init_one(struct device_node *dn,
int parent_irq;

parent_irq = irq_of_parse_and_map(dn, irq);
if (parent_irq < 0) {
if (!parent_irq) {
pr_err("failed to map interrupt %d\n", irq);
return parent_irq;
return -EINVAL;
}

data->irq_map_mask |= be32_to_cpup(map_mask + irq);
Expand Down

0 comments on commit 714710e

Please sign in to comment.